Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify ModelMapper to return DynamicKubernetesObject #3770

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

scovl
Copy link
Contributor

@scovl scovl commented Oct 27, 2024

I solved the issue #3336 by modifying the getApiTypeClass method in ModelMapper.java to return DynamicKubernetesObject.class when a specific class for a given GroupVersionKind is not found. This change enables the Kubernetes Java client to handle YAML resources of any type without differentiating between specific kind values.

By defaulting to a dynamic Kubernetes object, the client can now load unstructured YAML, extract the necessary apiVersion and kind, map it to a generic handler, and interact with the Kubernetes API accordingly. This approach allows for the submission and management of any YAML resource, enhancing the client's flexibility and resolving the issue of handling resources without prior knowledge of their types.

@brendandburns @yue9944882

/lgtm

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2024
@brendandburns brendandburns reopened this Oct 28, 2024
@brendandburns
Copy link
Contributor

For some reason this didn't trigger CI/CD the first time, so close/reopen to re-trigger CI/CD.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, scovl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit a495270 into kubernetes-client:master Oct 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants