Modify ModelMapper to return DynamicKubernetesObject #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for unknown GroupVersionKinds
k8s-ci-robot
added
cncf-cla: yes
|
For some reason this didn't trigger CI/CD the first time, so close/reopen to re-trigger CI/CD. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, scovl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I solved the issue #3336 by modifying the
getApiTypeClassmethod inModelMapper.javato returnDynamicKubernetesObject.classwhen a specific class for a givenGroupVersionKindis not found. This change enables the Kubernetes Java client to handle YAML resources of any type without differentiating between specifickindvalues.By defaulting to a dynamic Kubernetes object, the client can now load unstructured YAML, extract the necessary
apiVersionandkind, map it to a generic handler, and interact with the Kubernetes API accordingly. This approach allows for the submission and management of any YAML resource, enhancing the client's flexibility and resolving the issue of handling resources without prior knowledge of their types.@brendandburns @yue9944882
/lgtm