Fixes watch conflict handling in informer and more test coverage #522
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
yue9944882
force-pushed
the
chore/integration-test-informer
branch
from
0a4b690 to
afa4671
Compare
yue9944882
changed the title
yue9944882
force-pushed
the
chore/integration-test-informer
branch
from
afa4671 to
0ec1855
Compare
| @@ -99,7 +99,7 @@ public void run() { | |||
| return; | |||
| } | |||
| log.error("{}#Watch failed as {} unexpected", apiTypeClass, t.getMessage(), t); | |||
| continue; | |||
| return; | |||
There was a problem hiding this comment.
the first bug uncovered by conflicting watch event
when a event arrives w/ ERROR type, the reflector should started another round of listing but it's now keeping retrying watch. the bug happens when the event is resourceVersion confliction error, the watch will always be failing b/c it requests w/ an outdated resourceVersion. should return in this case, so that it can fetches the latest resourceVersion by re-listing
/cc @brendandburns
yue9944882
force-pushed
the
chore/integration-test-informer
branch
from
0ec1855 to
c838490
Compare
yue9944882
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
No description provided.