-
Notifications
You must be signed in to change notification settings - Fork 556
Fix buffer trim while sending websocket messages #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @brendandburns |
@mojojoji Looks like the CLA is not coming through which is blocking the merge... could you check the status and that the email addresses tally please? (Or post another comment and see if that makes it take notice!) Thanks! |
CLA signed |
fixes #112 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, mojojoji The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Buffer.from
creates a new buffer of the same length of initial buffer or data. The data send over websocket needs to append one byte to identify message type (stdout/stdin/sterr).This merge request creates the buffer with length = 1+ data length and copies over the data/