Skip to content

Update generate-javascript.yml #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2023
Merged

Update generate-javascript.yml #1214

merged 1 commit into from
Aug 23, 2023

Conversation

brendandburns
Copy link
Contributor

Another cherry-pick to get this working again.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from drubin August 21, 2023 21:55
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 21, 2023
mstruebing
mstruebing reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@mstruebing mstruebing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Why do we need to cherry-pick here?
Is it because our master branch is not up to date with what kubernetes-client/gen:master is using because we are working on release-1.x?

@brendandburns
Copy link
Contributor Author

Yeah, the main problem is that the kubernetes-client/gen repo got updated to support fetch instead of creating a branch. So we're trying to support two different generators after the same repo.

I probably should just create a branch rather than cherry-pick, but for now this is kind of a manual branch.

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6305ecd into master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mstruebing mstruebing mstruebing left review comments

@drubin drubin Awaiting requested review from drubin

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brendandburns @k8s-ci-robot @mstruebing