Skip to content

FEAT: Adding support for multiple client #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023
Merged

FEAT: Adding support for multiple client #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function fileExists(filepath: string): boolean {
}

export class KubeConfig {
private static authenticators: Authenticator[] = [
private authenticators: Authenticator[] = [
new AzureAuth(),
new GoogleCloudPlatformAuth(),
new ExecAuth(),
Expand Down Expand Up @@ -450,7 +450,7 @@ export class KubeConfig {
if (!user) {
return;
}
const authenticator = KubeConfig.authenticators.find((elt: Authenticator) => {
const authenticator = this.authenticators.find((elt: Authenticator) => {
return elt.isAuthProvider(user);
});

Expand Down
2 changes: 1 addition & 1 deletion src/config_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,7 +1169,7 @@ describe('KubeConfig', () => {
// TODO: inject the exec command here?
const opts = {} as requestlib.Options;
await config.applyToRequest(opts);
let execAuthenticator = (KubeConfig as any).authenticators.find(
let execAuthenticator = (config as any).authenticators.find(
(authenticator) => authenticator instanceof ExecAuth,
);
expect(execAuthenticator.tokenCache['exec']).to.deep.equal(JSON.parse(responseStr));
Expand Down