Fixes to be more lenient on configs without users. #147
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
src/config_types.ts
Outdated
| @@ -101,7 +101,7 @@ function contextIterator(): u.ListIterator<any, Context> { | |||
| if (!elt.context.cluster) { | |||
| throw new Error(`contexts[${i}].context.cluster is missing`); | |||
| } | |||
| if (!elt.context.user) { | |||
| if (elt.context.user === undefined) { | |||
There was a problem hiding this comment.
Not quite sure of the import of this change. Is the intention to permit the empty string (or null), but still forbid undefined?
There was a problem hiding this comment.
That's what I was going for. TBH, I don't know what the "right" expectation is here.... I can test with a config with no user at all and see what kubectl does...
There was a problem hiding this comment.
Looks like kubectl is ok with it 100% missing, so I just removed this.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This makes the library work with kubernetes-dind clusters.