Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom path for service account token (supporting TokenVolume projection) #1549

Merged

Conversation

omerlh
Copy link
Contributor

@omerlh omerlh commented Jan 30, 2024

fix #1528

I am not sure about the CA - I need to see if it will be there if using the projected volume 馃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @omerlh!

It looks like this is your first PR to kubernetes-client/javascript 馃帀. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 馃槂

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 30, 2024
@omerlh omerlh changed the title Master feat: custom path for service account token (supporting TokenVolume projection) Jan 30, 2024
@omerlh
Copy link
Contributor Author

omerlh commented Jan 30, 2024

While investigating the issue with CA and token projection I found this issue kubernetes/kubernetes#53315, I asked for help on Kubernetes slack

@omerlh omerlh force-pushed the feat/service-account-custom-path branch from a369b3a to 307390e Compare January 30, 2024 14:25
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2024
@omerlh omerlh force-pushed the feat/service-account-custom-path branch from 307390e to c423a05 Compare January 30, 2024 14:27
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2024
@omerlh omerlh force-pushed the feat/service-account-custom-path branch from c423a05 to de18d0e Compare January 30, 2024 14:28
@omerlh
Copy link
Contributor Author

omerlh commented Jan 30, 2024

When using TokenProjection need also to mount the custom config map kube-root-ca.crt with the API server CA certificate so I add the option to specify path to the CA as well

@brendandburns
Copy link
Contributor

/lgtm
/approve

Thanks for the PR!

Once this merges, can you cherrypick it into the release-1.x branch also?

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2024
@brendandburns
Copy link
Contributor

ugh, looks like we need to fix the linter somewhat.

@omerlh
Copy link
Contributor Author

omerlh commented Jan 31, 2024

Yeah, the linter error does not look related to my changes so I am not sure what to do, I think need to upgrade linter rules maybe?

@mstruebing
Copy link
Member

Hey @omerlh I think the linter errors are not really failing, prettier is what is failing.
If I run npm run format and after that npm run lint I get an exit code of zero.
Without running npm run format it's 1. So if you run npm run format and commit and push these changes the linter should be satisfied.

I'm not sure about our linter setup though, we should probably switch to eslint or something else which is supported as tslint is deprecated since quite a while (2019)

@omerlh omerlh force-pushed the feat/service-account-custom-path branch from de18d0e to 342b796 Compare January 31, 2024 11:45
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@omerlh
Copy link
Contributor Author

omerlh commented Jan 31, 2024

Sure, I just did - let's see if this will help!

@mstruebing
Copy link
Member

/lgtm
/approve

Thank you for your contribution 馃帀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, mstruebing, omerlh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,mstruebing]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use this client with TokenVolume Projection
4 participants