Skip to content

Conversation

brendandburns
Copy link
Contributor

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2019
@itowlson
Copy link
Contributor

itowlson commented Feb 7, 2019

Should we regenerate package-lock.json to match before merging?

@drubin
Copy link
Contributor

drubin commented Feb 7, 2019

Should we regenerate package-lock.json to match before merging?

Yes, we should. I added a "test" for this but I didn't take into account CI first runs npm ci which updates the package-lock.json will add a basic test before we run npm ci

@drubin
Copy link
Contributor

drubin commented Feb 7, 2019

@brendanburns Also any chance we can make it part of the release process to also add a github release? many people subscribe to only releases so they can be notified when we publish new releases?

I noticed we haven't published a release since 0.7.0 https://github.com/kubernetes-client/javascript/releases

@brendandburns
Copy link
Contributor Author

@drubin Yeah, that's a good point. I filed #208 to track this.

@drubin
Copy link
Contributor

drubin commented Feb 8, 2019

Thanks @brendandburns

@brendandburns
Copy link
Contributor Author

@drubin I sent #210 to improve things. Any chance we can merge this PR?

Thanks!

@drubin
Copy link
Contributor

drubin commented Feb 9, 2019

@brendandburns the package-lock.json still needs to be updated(else every time you npm install you will get a dirty tree) .

If you set that also to 0.8.2 it should be good to merge.

@brendandburns
Copy link
Contributor Author

oops, good reminder. Fixed.

@brendandburns
Copy link
Contributor Author

@drubin is there a way for us to extend our CI/CD so that it would fail in situations like this?

@drubin
Copy link
Contributor

drubin commented Feb 9, 2019

/lgtm

Will submit a pr when I get a second just kinsa busy this week end

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit d8d1193 into kubernetes-client:master Feb 9, 2019
@brendandburns brendandburns deleted the version branch July 8, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants