-
Notifications
You must be signed in to change notification settings - Fork 557
Rev version to 0.8.2 now that 0.8.1 is published. #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Should we regenerate |
Yes, we should. I added a "test" for this but I didn't take into account CI first runs |
@brendanburns Also any chance we can make it part of the release process to also add a github release? many people subscribe to only releases so they can be notified when we publish new releases? I noticed we haven't published a release since 0.7.0 https://github.com/kubernetes-client/javascript/releases |
Thanks @brendandburns |
@brendandburns the package-lock.json still needs to be updated(else every time you npm install you will get a dirty tree) . If you set that also to 0.8.2 it should be good to merge. |
1304cdd
to
c8a5dc0
Compare
oops, good reminder. Fixed. |
@drubin is there a way for us to extend our CI/CD so that it would fail in situations like this? |
/lgtm Will submit a pr when I get a second just kinsa busy this week end |
@itowlson @drubin