Skip to content

Add pre-push check for tests and linter #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2019

Conversation

drubin
Copy link
Contributor

@drubin drubin commented May 31, 2019

As discussed about automatic pre-push check.

I could also move it to pre-commit check but I thought this seemed better.

/assign @brendandburns

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2019
@k8s-ci-robot k8s-ci-robot requested review from itowlson and mbohlool May 31, 2019 10:37
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 31, 2019
@brendandburns
Copy link
Contributor

This LGTM, are all of the new dependencies in package-lock.json due to the new husky dependency?

@drubin
Copy link
Contributor Author

drubin commented May 31, 2019

@brendanburns wow yes it seems so :( https://github.com/typicode/husky/blob/master/package.json#L50

They are only devDependancies though.

I can also switch this out for a manual implementation where you symlink a .hooks/pre-push a file that simply runs the command.

It just becomes opt-in vs automatic, either way, I am happy.

@brendandburns
Copy link
Contributor

No, this is fine, just seemed like a lot, but hey, that's node for you...

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, drubin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2019
@k8s-ci-robot k8s-ci-robot merged commit ba01b3d into kubernetes-client:master May 31, 2019
@drubin drubin deleted the add-husky branch June 4, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants