Skip to content

add github action. #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2020
Merged

add github action. #433

merged 1 commit into from
Apr 20, 2020

Conversation

brendandburns
Copy link
Contributor

cc @drubin

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from drubin and mbohlool April 20, 2020 16:21
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2020
drubin
drubin reviewed Apr 20, 2020
View reviewed changes
.github/workflows/test.yml Outdated
runs-on: ubuntu-latest
strategy:
matrix:
node: [ '10', '8' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can add ['12]

Suggested change
node: [ '10', '8' ]
node: [ '12', '10', '8' ]

As this is the latest LTS versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done (removed '8')

drubin
drubin reviewed Apr 20, 2020
View reviewed changes
.github/workflows/test.yml
- uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
- run: npm install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add back
https://github.com/kubernetes-client/javascript/blob/master/.travis.yml#L6-L9

Suggested change
- run: npm install
# Pre check to check that version matches package-lock.json
# needs to happen before npm install
- run: node version-check.js
- run: npm install

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

drubin
drubin reviewed Apr 20, 2020
View reviewed changes
.github/workflows/test.yml Outdated
node-version: ${{ matrix.node }}
- run: npm install
- run: npm test
- run: npm lint No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing new line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

drubin
drubin suggested changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@drubin drubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also remove the .travis.yml so its not confusing?

Some small suggestions but thanks for getting on this so quick! Sorry I was busy and didn't have time to get to it this week end.

@drubin
Copy link
Contributor

drubin commented Apr 20, 2020

Can these be activated before merging? or I guess they can't

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2020
drubin
drubin approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@drubin drubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm but I can't run it on this repo

@brendandburns
Copy link
Contributor Author

Comments addressed. There is some tool that looks like it can run it locally (https://github.com/nektos/act) if I run into trouble validating this or need to make a bunch of changes, I will try that.

@brendandburns
Copy link
Contributor Author

@drubin I think the /lgtm needs to be on it's own line :)

@drubin
Copy link
Contributor

drubin commented Apr 20, 2020

/lgtm

Sorry :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7d1c65a into kubernetes-client:master Apr 20, 2020
@brendandburns brendandburns mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbohlool mbohlool Awaiting requested review from mbohlool

1 more reviewer

@drubin drubin drubin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@drubin drubin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brendandburns @k8s-ci-robot @drubin