Skip to content

Update to Kubernetes API Version 1.18 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2020
Merged

Update to Kubernetes API Version 1.18 #445

merged 3 commits into from
May 14, 2020

Conversation

tux-rampage
Copy link
Contributor

The OpenAPI-Spec this library was generated for is outdated (v1.15)
This PR aims to provide updated API objects for the current stable release (1.18)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @tux-rampage!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 11, 2020
@tux-rampage
Copy link
Contributor Author

This should fix #438

@tux-rampage
Copy link
Contributor Author

/assign @mbohlool

@brendandburns
Copy link
Contributor

Thanks for doing this. Can you split this into two commits:

@tux-rampage
Copy link
Contributor Author

Yes. I can do that tomorrow.

@tux-rampage
Update generator settings
33d2aff
@tux-rampage
Regenerate api from Kubernetes 1.18 OpenAPI specs
a2e0c3e
@tux-rampage
Remove unused import of removed api type
a00b451 
The RollbackConfig type from axtension v1beta1 has
been removed from the k8s api. This import is not
used anyways so removal should be safe.
@tux-rampage
Copy link
Contributor Author

@brendanburns I've splitted the commit into three commits:

  1. Changes to the api gen config
  2. Re-generated API code
  3. Manual changes

I hope this helps

@brendandburns
Copy link
Contributor

thanks, it makes it much easier to review.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tux-rampage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit e150480 into kubernetes-client:master May 14, 2020
@brendandburns brendandburns mentioned this pull request May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@drubin drubin Awaiting requested review from drubin

Assignees

@brendandburns brendandburns

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tux-rampage @k8s-ci-robot @brendandburns @mbohlool