-
Notifications
You must be signed in to change notification settings - Fork 557
Update cp.ts #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cp.ts #521
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @Nebojsa92! |
This looks reasonable to me, but we need you to sign the CLA. Tests also failed, but that looks like a flake and I've poked them to re-run. Thanks! |
Actually the unit tests are failing w/ a legit problem, please fix the test too. |
It looks make sense to me too Believe just change this line will make the test work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test file updated
I've changed cp_test.ts file. That should do it. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, Nebojsa92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's faster to copy compressed data, and, in my case, it prevented following error:
"UnhandledPromiseRejectionWarning: Error: TAR_BAD_ARCHIVE: Truncated input (needed 31232 more bytes, only 0 available)"