Skip to content

Conversation

Nebojsa92
Copy link
Contributor

It's faster to copy compressed data, and, in my case, it prevented following error:
"UnhandledPromiseRejectionWarning: Error: TAR_BAD_ARCHIVE: Truncated input (needed 31232 more bytes, only 0 available)"

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 6, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @Nebojsa92!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2020
@brendandburns
Copy link
Contributor

This looks reasonable to me, but we need you to sign the CLA.

Tests also failed, but that looks like a flake and I've poked them to re-run.

Thanks!

@brendandburns
Copy link
Contributor

Actually the unit tests are failing w/ a legit problem, please fix the test too.

@vip30
Copy link
Contributor

vip30 commented Oct 8, 2020

It looks make sense to me too

Believe just change this line will make the test work
https://github.com/kubernetes-client/javascript/blob/master/src/cp_test.ts#L24

Copy link
Contributor Author

@Nebojsa92 Nebojsa92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test file updated

@Nebojsa92
Copy link
Contributor Author

This looks reasonable to me, but we need you to sign the CLA.

Tests also failed, but that looks like a flake and I've poked them to re-run.

Thanks!

I've changed cp_test.ts file.
Also I've signed CLA.

That should do it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 11, 2020
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Nebojsa92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4d40e96 into kubernetes-client:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants