Fix timeout on watch.js requestOptions

[jhagestedt]

The watching of Kubernetes object stops after 60 seconds - as the default timeout of 60 seconds is used.
It should be set to 0 - so infinite or at least be more configureable.

Using the RequestInterface to configure this is not the best option as in line 70 the request options gets applied to the config but not taken from any passed configuration.

Also the forever flag could be set.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @jhagestedt!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[brendandburns]

change looks ok, but validation tests are failing

[jhagestedt]

change looks ok, but validation tests are failing

I think because of other changes not mine :D

[brendandburns]

Yep, looks like a different problem :( I will fix and then we can merge this. Not sure how things got broken.

[brendandburns]

@jhagestedt I fixed the CI/CD errors, please re-base and I think this will be ready to go.

[jhagestedt]

/assign @brendandburns

[brendandburns]

@jhagestedt thanks for updating the PR, but your rebase got messed up somehow (there are like 14 commits that aren't part of this PR)

Once you fix up the PR, I'm happy to merge this PR.

[brendandburns]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, jhagestedt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jkryl]

Hi @jhagestedt, I was looking at the fix as I was fixing another problem in the same area. It's not 100% clear to me if these newly added options have any impact on the client. I'm looking at request library source code from master:

The forever option sets keep-alive for HTTP connection, which seems to be the exact opposite of what we want. AFAIK keep-alive keeps a connection alive between the requests. However, a watcher connection lasts until closed from either side. We should never get into a situation when we want to keep it alive for another request.

We set the timeout option however the first thing that request lib seems to do is delete the option and implement its own timeout (https://github.com/request/request/blob/3c0cddc7c8eb60b470e9519da85896ed7ee0081e/request.js#L748). So I'm wondering if that has any impact on behaviour of the client at all. I have seen issues with inactive watcher connections when using AKS on azure, so there seems to be a problem with that for sure. I'm just not clear how this can fix the problem.