Skip to content

Explicitly abort and destroy active requests before re-initiating a watch. #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Explicitly abort and destroy active requests before re-initiating a watch. #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export class ListWatch<T extends KubernetesObject> implements ObjectCache<T>, In
private readonly indexCache: { [key: string]: T[] } = {};
private readonly callbackCache: { [key: string]: Array<ObjectCallback<T>> } = {};
private stopped: boolean;
private activeRequest: any;

public constructor(
private readonly path: string,
Expand All @@ -26,6 +27,7 @@ export class ListWatch<T extends KubernetesObject> implements ObjectCache<T>, In
this.callbackCache[ERROR] = [];
this.resourceVersion = '';
this.stopped = true;
this.activeRequest = null;
if (autoStart) {
this.start();
}
Expand Down Expand Up @@ -106,7 +108,19 @@ export class ListWatch<T extends KubernetesObject> implements ObjectCache<T>, In
}
});
this.addOrUpdateItems(list.items);
await this.watch.watch(
if (this.activeRequest != null) {
try {
this.activeRequest.abort();
} catch (ignore) {
// pass
}
try {
this.activeRequest.destroy();
} catch (ignore) {
// pass
}
}
this.activeRequest = await this.watch.watch(
this.path,
{ resourceVersion: list.metadata!.resourceVersion },
this.watchHandler.bind(this),
Expand Down