-
Notifications
You must be signed in to change notification settings - Fork 556
Regenerate for Kubernetes 1.21.1 #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@brendandburns can you rebase to remove the odd double version bump/downgrade? |
@@ -21,7 +21,7 @@ export GEN_COMMIT=d71ff1efd | |||
export USERNAME=kubernetes | |||
|
|||
# Kubernetes branch/tag to get the OpenAPI spec from. | |||
export KUBERNETES_BRANCH="v1.20.2" | |||
export KUBERNETES_BRANCH="v1.21.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a changelog update?
@brendandburns the commits still seemed odd there are 2 version bumps in this MR and the duplicate MR to version bump? which is correct? |
I approved the other MR first, but this also looks good, not sure when you want to do the release though so I will leave you to add the |
I think the policy is to keep the version in (still figuring out the right way to do versioning w/ npm...) Thanks! |
/lgtm |
No description provided.