Skip to content

Regenerate for Kubernetes 1.21.1 #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2021

Conversation

brendandburns
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 14, 2021
@k8s-ci-robot k8s-ci-robot requested a review from drubin May 14, 2021 16:24
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2021
@drubin
Copy link
Contributor

drubin commented May 15, 2021

@brendandburns can you rebase to remove the odd double version bump/downgrade?

@@ -21,7 +21,7 @@ export GEN_COMMIT=d71ff1efd
export USERNAME=kubernetes

# Kubernetes branch/tag to get the OpenAPI spec from.
export KUBERNETES_BRANCH="v1.20.2"
export KUBERNETES_BRANCH="v1.21.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a changelog update?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2021
@drubin
Copy link
Contributor

drubin commented May 17, 2021

@brendandburns the commits still seemed odd there are 2 version bumps in this MR and the duplicate MR to version bump? which is correct?

@drubin
Copy link
Contributor

drubin commented May 17, 2021

I approved the other MR first, but this also looks good, not sure when you want to do the release though so I will leave you to add the /lgtm flag if you are happy else just retag me.

@brendandburns
Copy link
Contributor Author

brendandburns commented May 17, 2021

I think the policy is to keep the version in package[-lock].json as the next release version. So this is fine to merge, and then eventually I will cut a release.

(still figuring out the right way to do versioning w/ npm...)

Thanks!

@drubin
Copy link
Contributor

drubin commented May 17, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 681af09 into kubernetes-client:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants