fix possible RCE in jsonpath-plus

[rluvaton]

JSONPath-Plus/JSONPath#182

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rluvaton / name: Raz Luvaton (1fcd9f8, cc31452)

[k8s-ci-robot]

Welcome @rluvaton!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[brendandburns]

Thanks for the PR. fwiw, I wouldn't classify this as an RCE, since this requires a user to explicitly load a configuration either from disk or from some other input. In such circumstances, users should be expected to sanity check their input before handing it over to the library.

Obviously from a defense in depth perspective it is worth fixing this and no one should expect that embedding Javascript into their JSONPath should work in a kubeconfig, so I'm onboard with merging this PR. But it's definitely not an RCE since there is nothing 'remote' about this particular library call. (I'm not even sure that it is a vulnerability, since it requires the user of the library to knowingly supply malicious input)

[rluvaton]

to be honest after I found that issue I looked at the top most packages that use that and fixed that in them to have better security in our ecosystem

The RCE was meant to be in the package itself (even though it's a feature)...

[brendandburns]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, rluvaton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment