Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iscsi: correct error message format #84

Merged
merged 1 commit into from
Jan 6, 2022
Merged

iscsi: correct error message format #84

merged 1 commit into from
Jan 6, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jan 6, 2022

Signed-off-by: Humble Chirammal hchiramm@redhat.com

/kind cleanup

-->

NONE

@humblec
iscsi: correct error message format
17d45fb 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 6, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 6, 2022
@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2022

/assign @andyzhangx

@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2022

The sanity test pass locally, but looks like its timedout in CI.

@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2022

/test pull-csi-driver-iscsi-sanity

@andyzhangx
Copy link
Member

my fault, it would be fixed by: #85, @humblec could you approve?

@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2022

my fault, it would be fixed by: #85, @humblec could you approve?

Done.. Hopefully after the merge, this pass.

@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2022

/test pull-csi-driver-iscsi-sanity

@humblec
Copy link
Contributor Author

humblec commented Jan 6, 2022

@andyzhangx cool, #85 fixed it. Thanks .. ptal.

andyzhangx
andyzhangx approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 79a34dc into kubernetes-csi:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humblec @andyzhangx @k8s-ci-robot