Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept provision/delete calls from PVCs that have the 'migrated-to' annotation of the provisioner name #412

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Accept provision/delete calls from PVCs that have the 'migrated-to' annotation of the provisioner name #412

merged 2 commits into from
Feb 26, 2020

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Feb 24, 2020 •
edited
Loading

/kind feature

Final piece to fix: kubernetes/kubernetes#79043

CSI Migration: Fixes CSI migration issue where PVCs provisioned before migration was turned on could not be deleted

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2020
@davidz627
Copy link
Contributor Author

/assign @msau42 @jsafrane

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 24, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2020
@davidz627
Copy link
Contributor Author

/retest

@davidz627
Copy link
Contributor Author

/cc @msau42 @jsafrane
this PR is ready for review

@davidz627
Copy link
Contributor Author

/retest

3 similar comments
@davidz627
Copy link
Contributor Author

/retest

@davidz627
Copy link
Contributor Author

/retest

@davidz627
Copy link
Contributor Author

/retest

@davidz627 davidz627 mentioned this pull request Feb 26, 2020
Merged
@msau42
Copy link
Collaborator

msau42 commented Feb 26, 2020

/lgtm
/approve

Can you make the release note more easily understandable by someone that doesn't have background on the issue? Something like "Fixes CSI migration issue where PVCs provisioned before migration was turned on could not be deleted"
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@davidz627
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8c55ff8 into kubernetes-csi:master Feb 26, 2020
@davidz627 davidz627 deleted the feature/migratedTo branch February 26, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@jsafrane jsafrane

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to check migrated PVs get deleted through CSI if CSI migration was enabled post provisioning
4 participants
@davidz627 @msau42 @k8s-ci-robot @jsafrane