This repository was archived by the owner on Apr 17, 2025. It is now read-only.
Improve usability of unmanaged namespaces #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it a nondestructive operation to switch a namespace from managed to unmanaged and back, by _not_ deleting the HC or anchors while a namespace is unmanaged. It also fixes one serious bug (namespaces could not be changed to roots because the unnamed namespace didn't match the regex) and adds a lot more details in the error messages. Finally, it allows users to fix broken hierarchies by removing a formerly-managed parent. I also changed the terminology from "excluded" to "unmanaged" throughout. Testing: This is hard to test automatically since it requires constant redeployments of HNC. So I did extensive manual testing instead: * Try to arrange hierarchies with unmanaged namespace, both excluded (e.g hnc-system) and ones that don't match the regex. Verify that the error messages clearly indicate the correct problem. * Create a legal hierarchy and then break it by changing the regex. Verify that I can fix it without restarting HNC. * Create a legal hierarchy, break it with the regex, and then restore it with the regex. Verify that the original hierarchy comes back. * Verify that anchors and hierarchyconfigs lose their finalizers when their namespaces become unmanaged, and get them back if they become managed again.
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @rjbez17 |
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
LGTM |
|
Ping @rjbez17 ? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it a nondestructive operation to switch a namespace
from managed to unmanaged and back, by not deleting the HC or anchors
while a namespace is unmanaged. It also fixes one serious bug
(namespaces could not be changed to roots because the unnamed namespace
didn't match the regex) and adds a lot more details in the error
messages. Finally, it allows users to fix broken hierarchies by removing
a formerly-managed parent.
I also changed the terminology from "excluded" to "unmanaged"
throughout.
Testing: This is hard to test automatically since it requires constant
redeployments of HNC. So I did extensive manual testing instead:
(e.g hnc-system) and ones that don't match the regex. Verify that the
error messages clearly indicate the correct problem.
Verify that I can fix it without restarting HNC.
with the regex. Verify that the original hierarchy comes back.
their namespaces become unmanaged, and get them back if they become
managed again.