Add support for code coverage #63
Conversation
`make coverage` will run tests with code coverage enabled, and will generate a coverage.html report (when run from the root directory), or $(BIN)-coverage.html when run inside an individual package.
k8s-ci-robot
added
the
cncf-cla: yes
|
LGTM |
|
LGTM Do we have a mechanism that can store and report coverage in PRs or on master? We've used codecov for this purpose before. This is only a nice-to-have for me, so not blocking for this PR |
|
LGTM |
|
@arschles I am not sure re: storing the coverage data on the PR. I am don't have sufficient GitHub and Travis expertise but I assume it should be somehow possible. I agree that it is nice-to-have (very nice to have because engineers are more ready to act on coverage numbers when they are made easily accessible) and hopefully someone may know just where to make tweaks to connect the dots in a future PR. |
|
@martinmaly agree. I've captured the code coverage capture-and-report work in #72 |
|
Although it looks like this was opened only 17 hours ago (short of the required full 1 business day), I'm deeming this ok to merge since it has 3 eligible LGTMs and doesn't impact any code or documentation |
make coveragewill run tests with code coverage enabled,and will generate a coverage.html report (when run from the root
directory), or $(BIN)-coverage.html when run inside an individual
package.