Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E test improvements #159

Merged
merged 1 commit into from
Feb 20, 2020
Merged

E2E test improvements #159

merged 1 commit into from
Feb 20, 2020

Conversation

barney-s
Copy link
Contributor

@barney-s barney-s commented Feb 12, 2020 •
edited

E2E test improvements

  • Run the controller in e2e test
  • Combine wordpress test with the existing e2e test
  • Use a kind cluster to do real e2e
  • Make example author and developer generic

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@barney-s barney-s force-pushed the e2e_test branch 2 times, most recently from ec37717 to 148779f Compare February 12, 2020 09:55
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2020
@barney-s barney-s force-pushed the e2e_test branch 3 times, most recently from 2c58eeb to a98e480 Compare February 12, 2020 22:01
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2020
@barney-s barney-s requested review from mortent and removed request for pwittrock February 12, 2020 22:05
@barney-s
Copy link
Contributor Author

@nan-yu - Please review. This runs the controller and does an actual E2E test .

@barney-s barney-s changed the title [WIP] Try running controller in e2e test E2E test improvements Feb 12, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2020
@barney-s barney-s mentioned this pull request Feb 12, 2020
Merged
@nan-yu
Copy link
Contributor

nan-yu commented Feb 12, 2020

LGTM. Thanks for automating the e2e test. It's much clean now!!! @barney-s

@barney-s
Copy link
Contributor Author

@mortent - Would you please review and LGTM

@barney-s barney-s force-pushed the e2e_test branch 2 times, most recently from 82418cf to 961d61a Compare February 13, 2020 19:57
nan-yu
nan-yu reviewed Feb 13, 2020
View reviewed changes
main.go Outdated Show resolved Hide resolved
@barney-s barney-s force-pushed the e2e_test branch 3 times, most recently from 5c3876b to e6f31ff Compare February 13, 2020 20:30
nan-yu
nan-yu reviewed Feb 13, 2020
View reviewed changes
main.go Outdated Show resolved Hide resolved
@barney-s barney-s force-pushed the e2e_test branch 2 times, most recently from 6787e6a to f84d0ad Compare February 13, 2020 20:52
@barney-s
Copy link
Contributor Author

/assign mortent

This was referenced Feb 15, 2020
Merged
Merged
@barney-s
Copy link
Contributor Author

@ant31 @janetkuo - would you please review and LGTM ?

nan-yu
nan-yu reviewed Feb 18, 2020
View reviewed changes
config/rbac/role.yaml Outdated Show resolved Hide resolved
@barney-s
E2E test improvements
bf99292 
- Run the controller in e2e test
- Combine wordpress test with the existing e2e test
- Use a kind cluster to do real e2e
- Add sync-period commandline parameter
- bump lint to v1.20.0 since it is timing out in macos CI test
@barney-s
Copy link
Contributor Author

/assign @ant31

@janetkuo
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit e266f27 into kubernetes-sigs:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nan-yu nan-yu nan-yu left review comments

@janetkuo janetkuo janetkuo approved these changes

@mattfarina mattfarina Awaiting requested review from mattfarina

@mortent mortent Awaiting requested review from mortent

Assignees

@mortent mortent

@ant31 ant31

@janetkuo janetkuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@barney-s @k8s-ci-robot @nan-yu @janetkuo @mortent @ant31