Skip to content

Conversation

1ms-ms
Copy link
Contributor

@1ms-ms 1ms-ms commented Aug 19, 2025

Issue

Description

Adding a possibility to specify WAFv2 with name annotation/ingressclassparam as another possiblity to build the WAFv2 association

I would like to provide WAFv2 name instead of ARN and have a function getArnByName to retrieve the ARN for me. In my implementation web acl name annotation/ingressclassparam takes priority over web acl arn annotation/ingressclassparam (although you should carefully review the logic for that as I may have missed some edge case not covered by tests I added or there may be a better way to write these conditions)

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 19, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 19, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @1ms-ms. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 19, 2025
@wweiwei-li
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2025
@shraddhabang shraddhabang self-assigned this Aug 20, 2025
Copy link
Collaborator

@shraddhabang shraddhabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 1ms-ms, shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2025
@shraddhabang shraddhabang added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit b5986dc into kubernetes-sigs:main Aug 21, 2025
5 checks passed
swarner1033 pushed a commit to swarner1033/aws-load-balancer-controller that referenced this pull request Sep 1, 2025
* feature: get waf arn from name

* feature: get waf arn from name

* feature: add docs and additional tests

* feature: add docs and additional tests

* feature: fix docs and webaclarn retrieval
swarner1033 pushed a commit to swarner1033/aws-load-balancer-controller that referenced this pull request Sep 1, 2025
* feature: get waf arn from name

* feature: get waf arn from name

* feature: add docs and additional tests

* feature: add docs and additional tests

* feature: fix docs and webaclarn retrieval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants