-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feature: get waf arn from name #4312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: get waf arn from name #4312
Conversation
Hi @1ms-ms. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 1ms-ms, shraddhabang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* feature: get waf arn from name * feature: get waf arn from name * feature: add docs and additional tests * feature: add docs and additional tests * feature: fix docs and webaclarn retrieval
* feature: get waf arn from name * feature: get waf arn from name * feature: add docs and additional tests * feature: add docs and additional tests * feature: fix docs and webaclarn retrieval
Issue
Description
Adding a possibility to specify WAFv2 with name annotation/ingressclassparam as another possiblity to build the WAFv2 association
I would like to provide WAFv2 name instead of ARN and have a function
getArnByName
to retrieve the ARN for me. In my implementationweb acl name
annotation/ingressclassparam takes priority overweb acl arn
annotation/ingressclassparam (although you should carefully review the logic for that as I may have missed some edge case not covered by tests I added or there may be a better way to write these conditions)Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯