-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit tests #420
Add Unit tests #420
Conversation
1.pkg/azuredisk/identity and version. 2.pkg/mounter/safe_mounter_unix.
Hi @Sakuralbj. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
it's better reuse original PR, actually you could use following command to do rebase, and then
|
/kind test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, Sakuralbj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1.pkg/azuredisk/identityserver and version.
2.pkg/mounter/safe_mounter_unix.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #382
Special notes for your reviewer:
Release note: