Ensure IPAddress has a ClusterName label as CAPI resources

[zhanggbj]

What this PR does / why we need it:
CAPI has a contract to label all created resources with a ClusterName label. CAPV will label IPAddressClaim. This PR is to ensure IPAddress also got one.

Please find more discussion in kubernetes-sigs/cluster-api-provider-vsphere#2218

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[schrej]

lgtm

I would really like to merge #203 before this, and then add this change there though. I'm still looking for some feedback on it, but rikatz hasn't gotten around to it yet.
Let me know if you'd like to have this right away. If someone else is available to take a look at #203 I'd of course appreciate that as well!

[schrej]

/remove-approve
/lgtm

Somewhat unintuitive 😄

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schrej, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [schrej]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhanggbj]

@schrej thanks for your review! No rush, but it would be great to merge this small change If everything works fine.
BTW, looks like the test is failing, and is there any way to retrigger it without push commit again?

[rikatz]

@zhanggbj IIRC you can trigger the tests directly back on pipelines...

Or...let's see if prow is smart:

/retest

[schrej]

We've merged #203 now. Could you adapt your PR? I think it makes sense to move this into the generic reconciler, probably around here: https://github.com/kubernetes-sigs/cluster-api-ipam-provider-in-cluster/blob/main/pkg/ipamutil/reconciler.go#L210

[schrej]

I finally figured out why the test is failing:

reconciler.go:133] "IPAddressClaim linked to a cluster that is not found, unable to determine cluster's paused state, skipping reconciliation" controller="ipaddressclaim" controllerGroup="ipam.cluster.x-k8s.io" controllerKind="IPAddressClaim" IPAddressClaim="test-ns-t25bg/test" namespace="test-ns-t25bg" name="test" reconcileID="764c6bb4-3a5e-4e90-a5e7-0f0fdf3bed9c"

Can you create the cluster you're referencing during that test to avoid reconciliation to be skipped?

[schrej]

/lgtm

[zhanggbj]

@schrej Thank you for fixing the test! I just came back from a vacation.