Add e2e test for internal load balancer #1245
Conversation
k8s-ci-robot
added
release-note-none
|
Hi @bfournie. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
test/e2e/e2e_test.go
Outdated
| Namespace: namespace.Name, | ||
| ClusterName: clusterName, | ||
| KubernetesVersion: e2eConfig.GetVariable(KubernetesVersion), | ||
| ControlPlaneMachineCount: ptr.To[int64](3), |
There was a problem hiding this comment.
to reduce costs maybe can be just one of each
|
seems correct, now need to know if that feature works :) you might need to run in your gcp test account or something to test it |
bfournie
force-pushed
the
internal-lb-e2e-test
branch
10 times, most recently
from
25eb857
to
9595691
Compare
|
/test pull-cluster-api-provider-gcp-e2e-test |
1 similar comment
|
/test pull-cluster-api-provider-gcp-e2e-test |
bfournie
force-pushed
the
internal-lb-e2e-test
branch
2 times, most recently
from
91abab8
to
f7f653b
Compare
Adds an e2e test when the internal load balancer is configured. This requires kubernetes-sigs#1222
bfournie
force-pushed
the
internal-lb-e2e-test
branch
from
f7f653b
to
32fe7ee
Compare
bfournie
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
do-not-merge/hold
|
/test pull-cluster-api-provider-gcp-e2e-test |
k8s-ci-robot
removed
the
do-not-merge/hold
| @@ -182,4 +182,28 @@ var _ = Describe("Workload cluster creation", func() { | |||
| }, result) | |||
| }) | |||
| }) | |||
|
|
|||
| Context("Creating a control-plane cluster with an internal load balancer", func() { | |||
| It("Should create a cluster with 1 control-plane and 1 worker node with an internal load balancer", func() { | |||
There was a problem hiding this comment.
i think that is fine for now, but we need to check if the LB created is internal, maybe do something similar what capz does: https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/3be87785773925374b601b3002c0c32edd5b08ec/test/e2e/azure_privatecluster.go#L47
thanks for adding more tests, this is cool
There was a problem hiding this comment.
Yes, using just the internal LB is a bit more complex as it will require adding a proxy or additional way to access the internal endpoint. I am currently working on a downstream test and will add an additional test here in the future. Thanks for the pointer to way capz does it, that's useful.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds an e2e test when the internal load balancer is configured. This requires #1222
Special notes for your reviewer:
TODOs:
Release note: