-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi master #47
Multi master #47
Commits on May 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8594a5a - Browse repository at this point
Copy the full SHA 8594a5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22a200d - Browse repository at this point
Copy the full SHA 22a200dView commit details
Commits on May 5, 2020
-
remove the projectID from PacketMachine crd
It does not look like the PacketMachine needs a ProjectID. It is a value that we get from the PacketCluster. It is not even generated from the `make examples` file and when applied via kubectl it fails because PachetMachine.ProjectID is a required field in openapi.
Gianluca Arbezzano committedMay 5, 2020 Configuration menu - View commit details
-
Copy full SHA for f3ff217 - Browse repository at this point
Copy the full SHA f3ff217View commit details -
Merge pull request #13 from gianarb/fix/packet-machine-crd-spec-proje…
…ctID remove the projectID from PacketMachine crd
Configuration menu - View commit details
-
Copy full SHA for ec6b1ee - Browse repository at this point
Copy the full SHA ec6b1eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 536b3a0 - Browse repository at this point
Copy the full SHA 536b3a0View commit details -
update the cluster template with required fields
Gianluca Arbezzano committedMay 5, 2020 Configuration menu - View commit details
-
Copy full SHA for c8f801e - Browse repository at this point
Copy the full SHA c8f801eView commit details -
Merge pull request #15 from gianarb/fix/cluster-example-fields
update the cluster template with required fields
Configuration menu - View commit details
-
Copy full SHA for fd70e71 - Browse repository at this point
Copy the full SHA fd70e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 044c112 - Browse repository at this point
Copy the full SHA 044c112View commit details -
At the end of the story it took me an hour to understand the issue and 1 minutes to fix it. I suppose. The kubebuilder installation process is already part of the Makefile, but it was not used in CI. now it should work.
Gianluca Arbezzano committedMay 5, 2020 Configuration menu - View commit details
-
Copy full SHA for 4f08400 - Browse repository at this point
Copy the full SHA 4f08400View commit details -
Merge pull request #17 from gianarb/fix/kubebuilder-in-ci
fix ci installing kubebuilder
Configuration menu - View commit details
-
Copy full SHA for 360a60a - Browse repository at this point
Copy the full SHA 360a60aView commit details -
It is cool that we cache the go dependency as a separate layer so images will take care of caching for us! But it does not come for free!!
Gianluca Arbezzano committedMay 5, 2020 Configuration menu - View commit details
-
Copy full SHA for 20ed1ce - Browse repository at this point
Copy the full SHA 20ed1ceView commit details -
Merge pull request #18 from gianarb/fix/ci-image-build
fix ci image build test
Configuration menu - View commit details
-
Copy full SHA for ca0fb08 - Browse repository at this point
Copy the full SHA ca0fb08View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd07139 - Browse repository at this point
Copy the full SHA dd07139View commit details -
Merge pull request #20 from packethost/align-dockerfile
Fix image build
Configuration menu - View commit details
-
Copy full SHA for 7771d02 - Browse repository at this point
Copy the full SHA 7771d02View commit details -
fix manager adding custerv1 schema types
The types.Machine or Cluster from v1alpha3 where not right registered to the manager
Gianluca Arbezzano committedMay 5, 2020 Configuration menu - View commit details
-
Copy full SHA for ab06c61 - Browse repository at this point
Copy the full SHA ab06c61View commit details -
Merge pull request #21 from gianarb/fix/register-cluterv1-schema
fix manager adding custerv1 schema types
Configuration menu - View commit details
-
Copy full SHA for 60483cd - Browse repository at this point
Copy the full SHA 60483cdView commit details
Commits on May 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c237615 - Browse repository at this point
Copy the full SHA c237615View commit details -
Merge pull request #23 from packethost/fix-kubebuilder-annotations
fix annotations so the CRDs are correct
Configuration menu - View commit details
-
Copy full SHA for 99f68e8 - Browse repository at this point
Copy the full SHA 99f68e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8001489 - Browse repository at this point
Copy the full SHA 8001489View commit details -
Merge pull request #24 from packethost/set-provider-id
set correct provider ID
Configuration menu - View commit details
-
Copy full SHA for 9f2a056 - Browse repository at this point
Copy the full SHA 9f2a056View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd5a224 - Browse repository at this point
Copy the full SHA fd5a224View commit details -
Merge pull request #26 from packethost/proper-packetcluster-status
proper cluster reconcile loop, remove finalizers on delete
Configuration menu - View commit details
-
Copy full SHA for 5134d42 - Browse repository at this point
Copy the full SHA 5134d42View commit details -
trigger finalizer even if the machine is already deleted from packet
If we attempt to remove a machine that is not running on Packet (for any reason), we are in a loop where the reconciler returns 404 from Packet API and the source never gets deleted. This code should check for a 404, and it should pass forward the finalizer trigger a garbage collection. I presume we do not need to check for the number of `instances` anymore, because if they are `0` we never get over the `not found error`.
Gianluca Arbezzano committedMay 6, 2020 Configuration menu - View commit details
-
Copy full SHA for a293edd - Browse repository at this point
Copy the full SHA a293eddView commit details -
bootstrap data secret must be set
From v1alpha2 to v1alpha3 the Bootstrap.Data field got deprecated in favour of Bootstrap.DataSecretName as you can see: https://cluster-api.sigs.k8s.io/developer/providers/v1alpha2-to-v1alpha3.html#data-generated-from-a-bootstrap-provider-is-now-stored-in-a-secret
Gianluca Arbezzano committedMay 6, 2020 Configuration menu - View commit details
-
Copy full SHA for 49ef02f - Browse repository at this point
Copy the full SHA 49ef02fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0bbc4b - Browse repository at this point
Copy the full SHA b0bbc4bView commit details -
Merge pull request #25 from gianarb/feature/skip-device-delete-if-not…
…-present trigger finalizer even if the machine is already deleted from packet
Configuration menu - View commit details
-
Copy full SHA for 2cd36af - Browse repository at this point
Copy the full SHA 2cd36afView commit details -
Merge pull request #28 from gianarb/fix/bootstrap-data-secret-check
bootstrap data secret must be set
Configuration menu - View commit details
-
Copy full SHA for b430e34 - Browse repository at this point
Copy the full SHA b430e34View commit details -
Merge pull request #29 from packethost/creation-id
handle no ID on creation
Configuration menu - View commit details
-
Copy full SHA for e59d076 - Browse repository at this point
Copy the full SHA e59d076View commit details -
fix packet go client wrong import
Gianluca Arbezzano committedMay 6, 2020 Configuration menu - View commit details
-
Copy full SHA for 6ab5908 - Browse repository at this point
Copy the full SHA 6ab5908View commit details -
Merge pull request #30 from gianarb/fix/packet-client-wrong-import
fix packet go client wrong import
Configuration menu - View commit details
-
Copy full SHA for 0be9274 - Browse repository at this point
Copy the full SHA 0be9274View commit details
Commits on May 7, 2020
-
The tags generated by the machine controller where not merged with the one passed from the MachineSpec. This PR fixes the issue. Now we can use those labels to filter devices via packet api.
Gianluca Arbezzano committedMay 7, 2020 Configuration menu - View commit details
-
Copy full SHA for da73f9d - Browse repository at this point
Copy the full SHA da73f9dView commit details -
get ip from control plan during cluster reconciliation
Gianluca Arbezzano committedMay 7, 2020 Configuration menu - View commit details
-
Copy full SHA for 330baca - Browse repository at this point
Copy the full SHA 330bacaView commit details -
Merge pull request #31 from gianarb/fix/merge-basetags
fix device tags
Configuration menu - View commit details
-
Copy full SHA for aa900b3 - Browse repository at this point
Copy the full SHA aa900b3View commit details -
handle more status coming from packet device api
By default we mark a machine failed when it returns a status that we do not know. I think it is very reasonable. But we were not handled a few status: provisioning and queued.
Gianluca Arbezzano committedMay 7, 2020 Configuration menu - View commit details
-
Copy full SHA for 8b6f4e7 - Browse repository at this point
Copy the full SHA 8b6f4e7View commit details -
Merge pull request #32 from gianarb/feature/get-master-ip
get ip from control plan during cluster reconciliation
Configuration menu - View commit details
-
Copy full SHA for 8c78b08 - Browse repository at this point
Copy the full SHA 8c78b08View commit details
Commits on May 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e8f4f46 - Browse repository at this point
Copy the full SHA e8f4f46View commit details -
add requeue timeouts for when machine cannot start because cluster or…
… bootstrap is not ready
Configuration menu - View commit details
-
Copy full SHA for deeab30 - Browse repository at this point
Copy the full SHA deeab30View commit details -
Merge pull request #35 from packethost/requeue-workers
add requeue timeouts for when machine cannot start because cluster or…
Configuration menu - View commit details
-
Copy full SHA for c29e9b9 - Browse repository at this point
Copy the full SHA c29e9b9View commit details -
Merge pull request #34 from packethost/simplify-build
simplify manual install of a new cluster with make target
Configuration menu - View commit details
-
Copy full SHA for 5ffcc3c - Browse repository at this point
Copy the full SHA 5ffcc3cView commit details -
handle device in provisioning state
By default we mark a machine as failed when we receive an unrecognized state. We were not handling the `provisioning` state.
Gianluca Arbezzano committedMay 8, 2020 Configuration menu - View commit details
-
Copy full SHA for d6a4cad - Browse repository at this point
Copy the full SHA d6a4cadView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3814d1 - Browse repository at this point
Copy the full SHA a3814d1View commit details -
Merge pull request #38 from gianarb/handle-provisioning-state
handle device in provisioning state
Configuration menu - View commit details
-
Copy full SHA for e14ee34 - Browse repository at this point
Copy the full SHA e14ee34View commit details
Commits on May 11, 2020
-
Merge pull request #39 from gianarb/chore/bump-cluster-api-0.3.5
bump cluster api to 0.3.5
Configuration menu - View commit details
-
Copy full SHA for 7f9b54d - Browse repository at this point
Copy the full SHA 7f9b54dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7858ace - Browse repository at this point
Copy the full SHA 7858aceView commit details -
Merge pull request #42 from packethost/update-controller-gen
ensure controller-gen exists and is minimum right version
Configuration menu - View commit details
-
Copy full SHA for 3931dd1 - Browse repository at this point
Copy the full SHA 3931dd1View commit details -
move from APIEndpoint to control plane endpoint
Gianluca Arbezzano committedMay 11, 2020 Configuration menu - View commit details
-
Copy full SHA for dfbdc7c - Browse repository at this point
Copy the full SHA dfbdc7cView commit details -
Merge pull request #40 from gianarb/feature/from-apiendpoint-to-contr…
…ol-endpoint move from APIEndpoint to control plane endpoint
Configuration menu - View commit details
-
Copy full SHA for 9bc9b20 - Browse repository at this point
Copy the full SHA 9bc9b20View commit details -
with the userdata currently it place in this PR the master gets a running kubelet. As reported on Jira, the kubelet is not running because we do not install a CNI yet, but this is not crucial at the moment. The userdata has some fixed values that we have to remove, like the ROLE. We will get there moving forward. I would like to fix the certificate issue first
Gianluca Arbezzano committedMay 11, 2020 Configuration menu - View commit details
-
Copy full SHA for ece43f8 - Browse repository at this point
Copy the full SHA ece43f8View commit details
Commits on May 12, 2020
-
make kubelet Status=Ready on master
Gianluca Arbezzano committedMay 12, 2020 Configuration menu - View commit details
-
Copy full SHA for c082c7e - Browse repository at this point
Copy the full SHA c082c7eView commit details -
Merge pull request #44 from gianarb/feature/kubelet-works-on-mater
kubelet runs on master
Configuration menu - View commit details
-
Copy full SHA for 6dff23a - Browse repository at this point
Copy the full SHA 6dff23aView commit details -
add support for packetmachinetemplate types
This is the generated code required to support a PacketMachineTemplate
Gianluca Arbezzano committedMay 12, 2020 Configuration menu - View commit details
-
Copy full SHA for eebc6d8 - Browse repository at this point
Copy the full SHA eebc6d8View commit details -
Merge pull request #45 from gianarb/feature/add-machinetemplates-types
add support for packetmachinetemplate types
Configuration menu - View commit details
-
Copy full SHA for 6b15da6 - Browse repository at this point
Copy the full SHA 6b15da6View commit details -
update example to use MachineDeployment
The right way to go here is via MachineSet, MachineDeployment. Those are almost the equivalent of ReplicaSet and Deployment for pod. * MachineSet represents an immutable group of Machine * MachineDeployment manage the lifecycle of MachineSet I updated our example to use those for pod rollout. By consequence the example also uses KubeadmConfigTemplate and PacketMachineTemplate Control Plane management will come in another PR.
Gianluca Arbezzano committedMay 12, 2020 Configuration menu - View commit details
-
Copy full SHA for 4ee1adf - Browse repository at this point
Copy the full SHA 4ee1adfView commit details -
Merge pull request #46 from gianarb/example/machine-deployment
update example to use MachineDeployment
Configuration menu - View commit details
-
Copy full SHA for f82fe55 - Browse repository at this point
Copy the full SHA f82fe55View commit details
Commits on May 13, 2020
-
template for multi master support via kubeadmcontrolplane
Gianluca Arbezzano committedMay 13, 2020 Configuration menu - View commit details
-
Copy full SHA for ee6954c - Browse repository at this point
Copy the full SHA ee6954cView commit details