Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto labeling cluster resources #1489

Closed
fabriziopandini opened this issue Oct 7, 2019 · 9 comments
Closed

Auto labeling cluster resources #1489

fabriziopandini opened this issue Oct 7, 2019 · 9 comments
Assignees
Labels
area/clusterctl Issues or PRs related to clusterctl kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@fabriziopandini
Copy link
Member

As an operator I would like to have a consistent set of labels for searching cluster resources.

Detailed Description

As the cluster API specification evolves, cluster specification is composed of a growing set of resources e.g. Cluster, AWSCluster, Machine, AWS machine, KubeConfigr, Certificate secrets, Kubeconfig secret etc.

By ensuring everything is part of a cluster consistently labeled it will be possible to simplify the management of a cluster definition and easily implement higher-level tools for deleting/pivoting a cluster

Goals

  • Apply a consistent set of labels to all the resources that are part of a cluster (including core objects, provider-specific objects and Kubernetes standard objects like secrets)

Non-Goals

  • Apply a consistent set of labels to the cluster API components itself (the manager, CRD definitions etc.)

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 7, 2019
@prankul88
Copy link
Contributor

@fabriziopandini I can work on this if you like.

@fabriziopandini
Copy link
Member Author

@prankul88 great! let's wait for some more feedback/issue triage before starting though

@ncdc ncdc added this to the v0.3.0 milestone Oct 9, 2019
@ncdc ncdc added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 9, 2019
@joonas
Copy link

joonas commented Dec 6, 2019

/assign @fabriziopandini

@fabriziopandini
Copy link
Member Author

In order to simplify for deleting/pivoting, on top of auto labeling, it is necessary also a generic convention for navigating objects and this requires more thinking
So I propose to decrease priority or to close and eventually re-open in future

@ncdc ncdc added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 6, 2019
@ncdc ncdc modified the milestones: v0.3.0, Next Dec 6, 2019
@ncdc
Copy link
Contributor

ncdc commented Dec 6, 2019

Done

@vincepri
Copy link
Member

/area clusterctl

@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label Dec 11, 2019
@fabriziopandini
Copy link
Member Author

@vincepri considering that clusterctl now relies on the OwnerRef chain (see https://master.cluster-api.sigs.k8s.io/clusterctl/provider-contract.html#ownerreferences-chain), I propose to close this issue.
WDYT?

@vincepri
Copy link
Member

vincepri commented Feb 2, 2020

/close

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

6 participants