-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 test/framework: expose CopyAndAmendClusterctlConfig function #10086
🌱 test/framework: expose CopyAndAmendClusterctlConfig function #10086
Conversation
/assign sbueringer fabriziopandini |
c3eea6f
to
78bc3a5
Compare
30924fe
to
28923e5
Compare
lgtm +/- linter |
28923e5
to
ed79879
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one nit from my side
ed79879
to
da0ff64
Compare
/lgtm |
LGTM label has been added. Git tree hash: 7b7954d8c17d154555aa5fdc1fc72d9df06a5df7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
In CAPV we made a copy of the
copyAndAmendClusterctlConfig
function because it was very useful in tests.In CAPV we use it to dynamically set a variable for different tests.
This PR makes the function
CopyAndAmendClusterctlConfig
and structCopyAndAmendClusterctlConfigInput
public so providers could make use of the function.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area e2e-testing