Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Bump Go to 1.22.0 #10159

Closed
wants to merge 1 commit into from
Closed

Conversation

EmilienM
Copy link

@EmilienM EmilienM commented Feb 15, 2024

What this PR does / why we need it:

Bump Go to 1.22.0.
Upstream Kubernetes bumped last week: kubernetes/kubernetes@ddb0b8d

/area dependency

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign killianmuldoon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 15, 2024
@EmilienM EmilienM changed the title Bump Go to 1.22.0 馃尡 Bump Go to 1.22.0 Feb 15, 2024
@k8s-ci-robot
Copy link
Contributor

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-verify-main 831b648 link true /test pull-cluster-api-verify-main
pull-cluster-api-test-main 831b648 link true /test pull-cluster-api-test-main
pull-cluster-api-e2e-blocking-main 831b648 link true /test pull-cluster-api-e2e-blocking-main
pull-cluster-api-build-main 831b648 link true /test pull-cluster-api-build-main
pull-cluster-api-apidiff-main 831b648 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilienM
Copy link
Author

/area dependency

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes and removed do-not-merge/needs-area PR is missing an area label labels Feb 15, 2024
@chrischdi
Copy link
Member

Note: upstream tracking issue:

We normally track bumping Go together with bumping k8s versions, xref: https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/ISSUE_TEMPLATE/kubernetes_bump.md#using-new-kubernetes-dependencies

Prior art: #9900

@sbueringer
Copy link
Member

/hold

We should not bump to Go 1.22 ahead of consuming upstream dependencies like controller-runtime / k8s.io that have been tested with Go 1.22.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2024
@EmilienM
Copy link
Author

/close

@k8s-ci-robot
Copy link
Contributor

@EmilienM: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants