Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove previously deprecated --metrics-bind-addr flag #11140

Merged

Conversation

Sunnatillo
Copy link
Contributor

@Sunnatillo Sunnatillo commented Sep 5, 2024

Removes MetricsBindAddr flag

What this PR does / why we need it:
follows : https://github.com/kubernetes-sigs/cluster-api/tree/main/docs/release/role-handbooks/release-lead#track-remove-previously-deprecated-code

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #11092
Edit:
Fixes: #10937

/area util

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/util Issues or PRs related to utils cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2024
@Sunnatillo Sunnatillo changed the title WIP: 🌱 Remove previously deprecated code 🌱 Remove previously deprecated code Sep 9, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, one nit

docs/book/src/reference/ports.md Outdated Show resolved Hide resolved
@sbueringer sbueringer changed the title 🌱 Remove previously deprecated code 🌱 Remove previously deprecated --metrics-bind-addr flag Sep 9, 2024
@sbueringer
Copy link
Member

Last nit from my side

/assign @fabriziopandini @chrischdi

Removes MetricsBindAddr flag

Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
@k8s-ci-robot
Copy link
Contributor

@Sunnatillo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 6e02691 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

Thx!

/test pull-cluster-api-e2e-blocking-main

/lgtm

I'll give folks a bit of time to review. If nobody gets around to it, feel free to ping me next week and I'll approve.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c7e603a5514e9da426a821cff296ec83c8fa58cb

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit c4d1b8a into kubernetes-sigs:main Sep 12, 2024
20 of 21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Sep 12, 2024
@Sunnatillo Sunnatillo deleted the remove-deprecated-code/sunnat branch September 12, 2024 12:39
@Sunnatillo Sunnatillo mentioned this pull request Sep 16, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/util Issues or PRs related to utils cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

Remove the deprecate metrics-bind-addr during 1.9 release cycle
5 participants