-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove previously deprecated --metrics-bind-addr flag #11140
🌱 Remove previously deprecated --metrics-bind-addr flag #11140
Conversation
4953d99
to
993b55a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, one nit
993b55a
to
5269d40
Compare
Last nit from my side /assign @fabriziopandini @chrischdi |
Removes MetricsBindAddr flag Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
5269d40
to
6e02691
Compare
@Sunnatillo: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thx! /test pull-cluster-api-e2e-blocking-main /lgtm I'll give folks a bit of time to review. If nobody gets around to it, feel free to ping me next week and I'll approve. |
LGTM label has been added. Git tree hash: c7e603a5514e9da426a821cff296ec83c8fa58cb
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Removes MetricsBindAddr flag
What this PR does / why we need it:
follows : https://github.com/kubernetes-sigs/cluster-api/tree/main/docs/release/role-handbooks/release-lead#track-remove-previously-deprecated-code
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #11092
Edit:
Fixes: #10937
/area util