Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting the removal of provider specific code #71

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Reverting the removal of provider specific code #71

merged 1 commit into from
Apr 16, 2018

Conversation

krousey
Copy link
Contributor

@krousey krousey commented Apr 16, 2018

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 16, 2018
@krousey krousey requested a review from krisnova April 16, 2018 19:52
@krisnova
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2018
krisnova
krisnova approved these changes Apr 16, 2018
View reviewed changes
Copy link
Contributor

@krisnova krisnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krisnova krisnova merged commit 0291e83 into kubernetes-sigs:master Apr 16, 2018
chuckha pushed a commit to chuckha/cluster-api that referenced this pull request Oct 2, 2019
@k8s-ci-robot
Merge pull request kubernetes-sigs#71 from chuckha/typo
1f59add 
Fix typo
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this pull request Jan 31, 2020
@sidharthsurana @k8s-ci-robot
Add a new MachineSpec for defining the instance on vsphere (kubernete…
479cd26 
…s-sigs#71)

* Move the MachineRef property into the ProviderConfig

* Move the `MachineRef` property from `ProviderStatus` to `ProviderConfig` object
* Upon creation of the `VirtualMachine` the `MachineRef` will be populated inside the spec
* Update the glog logs to use higher verbosity for improved readability of logs

Resolves kubernetes-sigs#82

Change-Id: I4ef1c5dec11d0c06dd777daae6500f4fe6f13241

* Add a new machinespec for defining the instance on vsphere

With the new structure we should be able to:
* Support defining multiple nics
* Support providing dhcp/static IP configuration for each nic
* Support customizing multiple disks if present
* Adds a optional flag called "vsphereCloudInit" to indicate if
  the template used has the vsphere datasource for cloud-init
  present and enabled

Note: This change does not change the existing behavior of using
the MachineVariables string map. This will be handled in the
subsequent patches.

Partially Resolves kubernetes-sigs#24
Partially Resolves kubernetes-sigs#28

Change-Id: Ia49b8ef9984cf6b82f4885179491ac3b3cc6f369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisnova krisnova krisnova approved these changes

Assignees

@krisnova krisnova

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krousey @krisnova @k8s-ci-robot