Support for hooks for resource cleanup during machine deletion #24
Assignees
Comments
|
From @roberthbailey on February 7, 2018 6:37 What types of resources are you thinking about? Would this be handled by finalizers for the machine objects (e.g. if on GCP we created an advanced route per machine then the finalizer for the machine would be responsible for deleting the route)? |
|
cc @k4leung4 |
|
I think that the finalizer approach we are taking satisfies this feature request, so I'm going to close this issue. /close |
jayunit100
pushed a commit
to jayunit100/cluster-api
that referenced
this issue
Jan 31, 2020
…s-sigs#71) * Move the MachineRef property into the ProviderConfig * Move the `MachineRef` property from `ProviderStatus` to `ProviderConfig` object * Upon creation of the `VirtualMachine` the `MachineRef` will be populated inside the spec * Update the glog logs to use higher verbosity for improved readability of logs Resolves kubernetes-sigs#82 Change-Id: I4ef1c5dec11d0c06dd777daae6500f4fe6f13241 * Add a new machinespec for defining the instance on vsphere With the new structure we should be able to: * Support defining multiple nics * Support providing dhcp/static IP configuration for each nic * Support customizing multiple disks if present * Adds a optional flag called "vsphereCloudInit" to indicate if the template used has the vsphere datasource for cloud-init present and enabled Note: This change does not change the existing behavior of using the MachineVariables string map. This will be handled in the subsequent patches. Partially Resolves kubernetes-sigs#24 Partially Resolves kubernetes-sigs#28 Change-Id: Ia49b8ef9984cf6b82f4885179491ac3b3cc6f369
jayunit100
pushed a commit
to jayunit100/cluster-api
that referenced
this issue
Jan 31, 2020
…on vsphere (kubernetes-sigs#72) The code now acts accordingly based on the availability of the new cloud-init datasource "VMwareGuestInfo" inside the template used. This availability can be set by the users in the spec using the flag "vsphereCloudInit" set to true. For usual upstream version of ubuntu cloud image that has been used so far, this flag need not be set at all and the controller will utilize the OVF properties available on the ubuntu cloud image to inject the cloud-init data. Note: The new static IP support is only available with the templates that have the vsphere cloud-init datasource. DHCP based IPs will continue to work as they have in the past. Going forward we prefer users creating a custom ubuntu cloud image that also has this new cloud-init datasource pre-installed. As that will give them the ability to use static IPs as well if they want. See https://github.com/akutz/cloud-init-vmware-guestinfo for more info on the new cloud-init datasource * Adds support for multiple nics * Adds support for static IP Resolves kubernetes-sigs#24 Resolves kubernetes-sigs#28 Change-Id: Id2dee12b382d57b6591f840dadd77a1c287667c4
anusha94
pushed a commit
to anusha94/cluster-api
that referenced
this issue
Jun 29, 2021
…or-byomachine-controller Fix rbac to secrets for byomachine controller
sbueringer
referenced
this issue
in sbueringer/cluster-api
Feb 1, 2022
🐛 Fix open, edit and reopen handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From @rsdcastro on January 29, 2018 22:9
Copied from original issue: kubernetes-retired/kube-deploy#531
The text was updated successfully, but these errors were encountered: