Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have upgrade functionality (as tool or server side) #28

Closed
rsdcastro opened this issue Apr 12, 2018 · 5 comments
Closed

Have upgrade functionality (as tool or server side) #28

rsdcastro opened this issue Apr 12, 2018 · 5 comments

Comments

@rsdcastro
Copy link

From @rsdcastro on January 29, 2018 22:39

Copied from original issue: kubernetes-retired/kube-deploy#537

@rsdcastro
Copy link
Author

From @roberthbailey on February 7, 2018 6:36

Alternatively, implement server side upgrades as part of the MachineDeployment resource type.

@rsdcastro rsdcastro added this to the cluster-api-beta-implementation milestone Apr 13, 2018
@rsdcastro rsdcastro modified the milestones: cluster-api-beta-implementation, cluster-api-alpha-implementation May 29, 2018
@rsdcastro
Copy link
Author

/assign @k4leung4

@roberthbailey roberthbailey changed the title Have a production-ready upgrade functionality (as tool or server side) Have upgrade functionality (as tool or server side) Jun 25, 2018
@roberthbailey
Copy link
Contributor

@k4leung4 - do machine deployments meet the exit criteria of this issue (for nodes)? I think they do, just wanting a second opinion.

If so, then we should either re-scope this to control plane upgrades or close it and spawn a separate issue for control plane upgrades.

@roberthbailey
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@roberthbailey: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chuckha pushed a commit to chuckha/cluster-api that referenced this issue Oct 2, 2019
Adds some tests and basic controller logic
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this issue Jan 31, 2020
…s-sigs#71)

* Move the MachineRef property into the ProviderConfig

* Move the `MachineRef` property from `ProviderStatus` to `ProviderConfig` object
* Upon creation of the `VirtualMachine` the `MachineRef` will be populated inside the spec
* Update the glog logs to use higher verbosity for improved readability of logs

Resolves kubernetes-sigs#82

Change-Id: I4ef1c5dec11d0c06dd777daae6500f4fe6f13241

* Add a new machinespec for defining the instance on vsphere

With the new structure we should be able to:
* Support defining multiple nics
* Support providing dhcp/static IP configuration for each nic
* Support customizing multiple disks if present
* Adds a optional flag called "vsphereCloudInit" to indicate if
  the template used has the vsphere datasource for cloud-init
  present and enabled

Note: This change does not change the existing behavior of using
the MachineVariables string map. This will be handled in the
subsequent patches.

Partially Resolves kubernetes-sigs#24
Partially Resolves kubernetes-sigs#28

Change-Id: Ia49b8ef9984cf6b82f4885179491ac3b3cc6f369
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this issue Jan 31, 2020
…on vsphere (kubernetes-sigs#72)

The code now acts accordingly based on the availability of the new cloud-init datasource
"VMwareGuestInfo" inside the template used. This availability can be set by the users in
the spec using the flag "vsphereCloudInit" set to true. For usual upstream version of
ubuntu cloud image that has been used so far, this flag need not be set at all and the
controller will utilize the OVF properties available on the ubuntu cloud image to inject
the cloud-init data.
Note: The new static IP support is only available with the templates that have the vsphere
cloud-init datasource. DHCP based IPs will continue to work as they have in the past.

Going forward we prefer users creating a custom ubuntu cloud image that also has this new
cloud-init datasource pre-installed. As that will give them the ability to use static IPs
as well if they want.

See https://github.com/akutz/cloud-init-vmware-guestinfo for more info on the new cloud-init
datasource

* Adds support for multiple nics
* Adds support for static IP

Resolves kubernetes-sigs#24
Resolves kubernetes-sigs#28

Change-Id: Id2dee12b382d57b6591f840dadd77a1c287667c4
anusha94 added a commit to anusha94/cluster-api that referenced this issue Jun 29, 2021
sbueringer referenced this issue in sbueringer/cluster-api Feb 1, 2022
🌱 Organize verify directory
abhinavmpandey08 added a commit to abhinavmpandey08/cluster-api that referenced this issue Feb 6, 2024
✨ Adding support for multiple registry mirrors in bottlerocket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants