Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcp-deployer delete can strand VMs if you are using MachineSets #82

Closed
rsdcastro opened this issue Apr 17, 2018 · 3 comments
Closed

gcp-deployer delete can strand VMs if you are using MachineSets #82

rsdcastro opened this issue Apr 17, 2018 · 3 comments
Assignees
@krousey @roberthbailey @k4leung4

Comments

@rsdcastro
Copy link

From @roberthbailey on March 18, 2018 18:0

If you create a MachineSet in your cluster and then run ./gcp-deployer delete, the delete command will delete each machine and then tear down the cluster. If you have machines that are part of a Machineset, while the gcp-deployer is tearing down the machines, the MachineSet is making sure that they exist. The gcp-deployer then deletes the master, leaking VM resources after the cluster is deleted.

Copied from original issue: kubernetes-retired/kube-deploy#654
@rsdcastro
Copy link
Author

From @krousey on March 19, 2018 15:40

cc @k4leung4 expressed interest in fixing this. Assigning to me since he's not in the k8s org yet.

/assign @krousey

@rsdcastro rsdcastro mentioned this issue Apr 17, 2018
Closed
@rsdcastro
Copy link
Author

/assign @k4leung4

Can you update status on this bug and close it out if it's fixed?

@roberthbailey
Copy link
Contributor

Closing since we are removing gcp-deployer. Please re-open if you still see this behavior with clusterctl.

/close

chuckha pushed a commit to chuckha/cluster-api that referenced this issue Oct 2, 2019
@k8s-ci-robot
Merge pull request kubernetes-sigs#82 from ericzhang08/add-goimports-…
a477868 
…verification

Add a goimports verification
chuckha pushed a commit to chuckha/cluster-api that referenced this issue Oct 2, 2019
@k8s-ci-robot
Merge pull request kubernetes-sigs#82 from fabriziopandini/reconciler…
43668d0 
…-init

Reconciler loop
jayunit100 pushed a commit to jayunit100/cluster-api that referenced this issue Jan 31, 2020
@sidharthsurana @k8s-ci-robot
Add a new MachineSpec for defining the instance on vsphere (kubernete…
479cd26 
…s-sigs#71)

* Move the MachineRef property into the ProviderConfig

* Move the `MachineRef` property from `ProviderStatus` to `ProviderConfig` object
* Upon creation of the `VirtualMachine` the `MachineRef` will be populated inside the spec
* Update the glog logs to use higher verbosity for improved readability of logs

Resolves kubernetes-sigs#82

Change-Id: I4ef1c5dec11d0c06dd777daae6500f4fe6f13241

* Add a new machinespec for defining the instance on vsphere

With the new structure we should be able to:
* Support defining multiple nics
* Support providing dhcp/static IP configuration for each nic
* Support customizing multiple disks if present
* Adds a optional flag called "vsphereCloudInit" to indicate if
  the template used has the vsphere datasource for cloud-init
  present and enabled

Note: This change does not change the existing behavior of using
the MachineVariables string map. This will be handled in the
subsequent patches.

Partially Resolves kubernetes-sigs#24
Partially Resolves kubernetes-sigs#28

Change-Id: Ia49b8ef9984cf6b82f4885179491ac3b3cc6f369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krousey krousey

@roberthbailey roberthbailey

@k4leung4 k4leung4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@krousey @rsdcastro @roberthbailey @k4leung4 @k8s-ci-robot