-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add controller workqueue option #2767
✨ Add controller workqueue option #2767
Conversation
cc @sebgl /assign @alvaroaleman |
/cc @fabriziopandini @chrischdi Makes it possible to pass in alternative queue implementations |
dcdb499
to
39ed0d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, leaving a hold in case you want to wait for further feedback, if not, feel free to cancel it
/hold
LGTM label has been added. Git tree hash: e9710eb26c1509bace62c462b330e576ae31ef74
|
/assign @vincepri |
Signed-off-by: Stefan Büringer buringerst@vmware.com
39ed0d5
to
6e23721
Compare
/lgtm |
LGTM label has been added. Git tree hash: bff80f2abc8ca783176b9bf7d3d4894af4dadb59
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer buringerst@vmware.com