-
Notifications
You must be signed in to change notification settings - Fork 1.2k
✨ Introduce hook points for the PriorityQueue #3345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This change introduces an interface defining hook points for the PriorityQueue. This helps enabling advanced use cases where reacting to internal events of the priority queue may be necessary, like the first hook point being introduced: OnBecameReady. OnBecameReady is called when items become ready for consumption, i.e. can be handed to GetWithPriority calls. Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: matheuscscp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @matheuscscp! |
Hi @matheuscscp. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This change introduces an interface defining hook points for the PriorityQueue. This helps enabling advanced use cases where reacting to internal events of the priority queue may be necessary, like the first hook point being introduced: OnBecameReady.
OnBecameReady is called when items become ready for consumption, i.e. can be handed to GetWithPriority calls.
Closes: #3334