-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dockershim with cri-dockerd #1151
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The reason it didn't fail sooner, was because the cri-dockerd socket was moved to the old dockershim location. sudo /usr/local/bin/cri-dockerd --network-plugin="" --container-runtime-endpoint=unix:///var/run/dockershim.sock For normal installations, there should be no need for dockershim.sock as it doesn't work anymore (since 1.27) commit f2091fc |
Looks like the test for docker had been disabled anyway ? This is probably why it breaks in production instead commit baefda3 |
This reverts commit baefda3.
Copied from commit f7333f2
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #870
Fixes #1162
Special notes for your reviewer:
Does this PR introduce a user-facing change?