Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update link to point to correct godep instructions #434

Merged
merged 1 commit into from
Mar 15, 2019
Merged

update link to point to correct godep instructions #434

merged 1 commit into from
Mar 15, 2019

Conversation

yangkev
Copy link
Contributor

@yangkev yangkev commented Feb 11, 2019

This fixes the broken link to point to the new docs for dependency management.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2019
@yangkev
Copy link
Contributor Author

yangkev commented Feb 11, 2019

/assign @feiskyer

@yangkev
Copy link
Contributor Author

yangkev commented Feb 12, 2019

Seems like this might not be pertinent since vndr is being used instead of godep.

@feiskyer
Copy link
Member

Yep, could you update the guides to vndr instead?

@yangkev
Copy link
Contributor Author

yangkev commented Feb 12, 2019 •
edited
Loading

👍

I updated the doc to point to vndr, as well as the general k8s dependency management (with godep) docs for best practices. I wonder if it is too confusing that there are two tools mentioned (vndr and godep) now?

@feiskyer
Copy link
Member

I wonder if it is too confusing that there are two tools mentioned (vndr and godep) now?

What do you think of spliting the docs into two parts: (1) restore the versions via godep; (2) update vendors for cri-tools with vndr (hack/update-vendor.sh will do this).

@feiskyer feiskyer added this to the v1.14 milestone Mar 14, 2019
@feiskyer
Copy link
Member

close-reopen for re-trigger Travis CI

@feiskyer feiskyer closed this Mar 15, 2019
@feiskyer feiskyer reopened this Mar 15, 2019
@feiskyer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2019
@feiskyer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, yangkev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7c1308e into kubernetes-sigs:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@yangkev @feiskyer @k8s-ci-robot