Environment.Test enhancements #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
sig/testing
vladimirvivien
changed the title
k8s-ci-robot
added
do-not-merge/work-in-progress
vladimirvivien
force-pushed
the
environment-test-enhancements
branch
from
004e8f7 to
763dc3f
Compare
vladimirvivien
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
examples/suites/featureset_test.go
Outdated
| "sigs.k8s.io/e2e-framework/pkg/features" | ||
| ) | ||
|
|
||
| // FeatureSetTest shows how Environment.Test can be used to |
There was a problem hiding this comment.
name change to TestFeatureSet
This patch introduces several enhancements to how feature tests are executed. 0) Environment.Test has been updated with the ability to test more than one tests 1) Test writer can specify a before/after feature action to be executed 3) Updated examples to highlight these changes Signed-off-by: Vladimir Vivien <vivienv@vmware.com>
vladimirvivien
force-pushed
the
environment-test-enhancements
branch
from
763dc3f to
ac21784
Compare
ShwethaKumbla
approved these changes
Aug 24, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ShwethaKumbla, vladimirvivien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several enhancements around Test/Feature lifecycles
env.Environment.BeforeTesttoenv.Environment.BeforeEachTest#35env.Environment.Testto execute feature sets #36env.Environment.BeforeEachFeatureandenv.Environment.AfterEachFeature#37Fixes #35
Fixes #36
Fixes #37