Skip to content

Remove csi-socket during uninstallation of plugin and use csi socket in /var/lib/kubelet/plugins/ #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2023
Merged

Remove csi-socket during uninstallation of plugin and use csi socket in /var/lib/kubelet/plugins/ #178

merged 2 commits into from
Nov 21, 2023

Conversation

ambiknai
Copy link
Contributor

@ambiknai ambiknai commented Nov 14, 2023 •
edited
Loading

Driver uses var/lib/kubelet/csi-plugins/. This PR has below changes

Move from var/lib/kubelet/csi-plugins/ to var/lib/kubelet/plugins/
Cleanup socket during uninstallation

@ambiknai
Remove csi-socket during uninstallation of plugin and use csi socket …
d67ce50 
…in /var/lib/kubelet/plugins/

Signed-off-by: Ambika Nair <ambiknai@in.ibm.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2023
@coveralls
Copy link

coveralls commented Nov 14, 2023 •
edited
Loading

Coverage Status

coverage: 82.792% (-0.6%) from 83.426%
when pulling dd2d0f9 on ambiknai:v5.1socket
into dcb5c13 on kubernetes-sigs:v5.1.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 15, 2023
@ambiknai ambiknai closed this Nov 21, 2023
@ambiknai ambiknai reopened this Nov 21, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 21, 2023
@ambiknai
Review comments
dd2d0f9 
Signed-off-by: Ambika Nair <ambiknai@in.ibm.com>
arahamad
arahamad approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@arahamad arahamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ambiknai, arahamad, sameshai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@arahamad arahamad merged commit 97d843f into kubernetes-sigs:v5.1 Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sameshai sameshai sameshai approved these changes

@arahamad arahamad arahamad approved these changes

@bradtopol bradtopol Awaiting requested review from bradtopol

Assignees

@arahamad arahamad

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ambiknai @coveralls @k8s-ci-robot @sameshai @arahamad