-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation instructions for Scoop
and Winget
#3376
Add installation instructions for Scoop
and Winget
#3376
Conversation
|
Welcome @ste93cry! |
Hi @ste93cry. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
blocked on #3379 |
I understand that you may not want to maintain the |
This should be done the same way as Even though it would be "automated", there is still maintenance overhead. Nothing stays static, so it's inevitable that something would change or break and it would need attention to troubleshoot - in an area most of the maintainers are not familiar with - and identify what needs to be updated. This is best kept out of kind itself and managed by winget-pkgs. |
Oh, and look at that! https://github.com/microsoft/winget-pkgs/tree/master/manifests/k/Kubernetes/kind/0.20.0 :) |
I understand the reasons you don't want to maintain the manifest, but this has nothing to do with mentioning in the documentation that the tool can be installed with these package managers, right? |
I see what you're saying, and I guess I agree. We don't maintain the brew or chocolatey packages, but we do have them listed in the documentation as possible ways to install kind. It almost feels like we should note a caveat there that the project has involvement in those packages and cannot vouch for their quality, but we've gone this long without it, so I don't see why these should be gated on doing something like that. If we even should. So sorry for the long delay, but I do think this could be useful for someone to have in the docs. /lgtm |
I'm in touch with the brew maintainers (heck somewhere there's a photo of me sitting with christoph at KubeCon while we developed the package on his laptop) and keep an eye on this one. It's true that the chocolatey package has this issue. We should split these into vetted and use at your own risk. KIND is used to manage privileged containers and must run with escalated permissions, kind itself is bad enough, but telling users to install packages we don't control is even worse and should be treated carefully. |
Let's add these, but follow-up by splitting first and third party and clarifying (more detailed proposal at #3644) Sorry for the delay. There's a LOT going on and there hasn't been much user demand for these versus the concerns and ongoing bug triage etc.... /lgtm #3644 to follow up on all third party install options. |
oops, I meant to merge this already but missed the hold-lift, we'll have to rebase it after #3660 merged, I meant for that PR to rebase this work instead of the other way around https://kind.sigs.k8s.io/docs/user/quick-start/#installing-with-a-package-manager |
3240fcf
to
ca9d450
Compare
Rebased 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold cancel
thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, ste93cry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Since
kind
is now installable via bothScoop
andWinget
, theQuick Start
guide should mention the installation instructions for those package managers.