Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump containerd to 1.7.15 #3568

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Bump containerd to 1.7.15 #3568

merged 1 commit into from
Apr 6, 2024

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Apr 5, 2024

Avoid the regression on exec containerd/containerd#10039

/hold
/assign @BenTheElder @dims

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2024
@dims
Copy link
Member

dims commented Apr 5, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@dims
Copy link
Member

dims commented Apr 5, 2024

/lgtm cancel

#29 6.560 error: pathspec 'v1.7.15' did not match any file(s) known to git

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@aojea
Copy link
Contributor Author

aojea commented Apr 5, 2024

/hold cancel

already published

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@BenTheElder
Copy link
Member

post-kind-push-base-image — Job failed.                     BaseSHA:9228b09c3f57e2302c423acb2b9f59c031acf764

??? why is this reporting on presubmit ??

@BenTheElder
Copy link
Member

oh, because you opened the branch in this repo.

please don't do that! 😅

@BenTheElder
Copy link
Member

BenTheElder commented Apr 6, 2024

When you click edit on github it will use your fork IFF you don't have write on the source repo, otherwise you have to go do it explicitly in your fork.

Not obvious behavior. The new branch will have been branch protected so it will be annoying to delete.

Not a big deal, but try to avoid in the future.

(I am guessing this is what happened based on the branch name following the pattern for github web editor patch authoring)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

/override post-kind-push-base-image

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Overrode contexts on behalf of BenTheElder: post-kind-push-base-image

In response to this:

/override post-kind-push-base-image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

/clear

@k8s-ci-robot k8s-ci-robot merged commit f47a5c6 into main Apr 6, 2024
24 checks passed
@BenTheElder
Copy link
Member

build will be in https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kind-push-base-image/1776405361725542400 (and then we should "promote" if it's working again)

@BenTheElder BenTheElder deleted the aojea-patch-1 branch April 6, 2024 00:30
@BenTheElder
Copy link
Member

Deleted the branch protection rule and then the branch.

@BenTheElder
Copy link
Member

build is green. promoted crane cp gcr.io/k8s-staging-kind/base:v20240406-f47a5c6c@sha256:20635e4687c401bd04e4c8e9049a4ddddcb5ac0ba1ffc7550cded45d5c04ac23 kindest/base:v20240406-f47a5c6c

@BenTheElder BenTheElder mentioned this pull request Apr 6, 2024
@aojea
Copy link
Contributor Author

aojea commented Apr 6, 2024

oh, because you opened the branch in this repo.

please don't do that! 😅

my bad, I used the UI to create the patch and I thought was using my fork :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants