-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump containerd to 1.7.15 #3568
Conversation
Avoid the regression on exec containerd/containerd#10039
/approve |
/lgtm cancel
|
/hold cancel already published |
??? why is this reporting on presubmit ?? |
oh, because you opened the branch in this repo. please don't do that! 😅 |
When you click edit on github it will use your fork IFF you don't have write on the source repo, otherwise you have to go do it explicitly in your fork. Not obvious behavior. The new branch will have been branch protected so it will be annoying to delete. Not a big deal, but try to avoid in the future. (I am guessing this is what happened based on the branch name following the pattern for github web editor patch authoring) /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, BenTheElder, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override post-kind-push-base-image |
@BenTheElder: Overrode contexts on behalf of BenTheElder: post-kind-push-base-image In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/clear |
build will be in https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kind-push-base-image/1776405361725542400 (and then we should "promote" if it's working again) |
Deleted the branch protection rule and then the branch. |
build is green. promoted |
my bad, I used the UI to create the patch and I thought was using my fork :( |
Avoid the regression on exec containerd/containerd#10039
/hold
/assign @BenTheElder @dims