-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround: v-data-table cannot scroll when the bar cannot be scrolled vertically #18
Workaround: v-data-table cannot scroll when the bar cannot be scrolled vertically #18
Conversation
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/label tide/merge-method-squash |
@@ -32,6 +32,8 @@ | |||
<template v-if="!editmode"> | |||
<SchedulingResults /> | |||
<ResourceDefinitionTree :items="treeData" /> | |||
<!-- This is need to avoid bug on vuetify --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required to work around the vuetify's bug, refer more details in #10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haosdent
Thanks for the suggestion.
Fixed. 🙏
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@haosdent |
/lgtm |
Fixes #10
It seems that v-data-table(vuetify component used to show table) cannot scroll horizontally when the v-navigation-drawer cannot be scrolled vertically 🤔 and it causes bug #10.
I add
<div>
with height as hot fix so that v-navigation-drawer always can be scrolled vertically./kind bug