Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build with cloudbuild for gcr #21

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Sep 12, 2021

part of #19

guide: https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md

For the most part, it is almost the same as the example in the guide.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2021
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2021
@sanposhiho
Copy link
Member Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 12, 2021
@sanposhiho
Copy link
Member Author

sanposhiho commented Sep 12, 2021

image pushing job will be have been created in kubernetes/test-infra#23567

@sanposhiho sanposhiho mentioned this pull request Sep 12, 2021
6 tasks
@sanposhiho
Copy link
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 30, 2021
# this must be specified in seconds. If omitted, defaults to 600s (10 mins)
timeout: 1200s
steps:
- name: gcr.io/cloud-builders/docker

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this conventional? I noticed some repos used gcr.io/k8s-staging-test-infra/gcb-docker-gcloud.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your build process is driven by a Makefile or similar, you can use GCB to invoke that. We provide the gcr.io/k8s-testimages/gcb-docker-gcloud image, which contains components that are likely to be useful for your builds.
https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md#makefile-build-example

So, gcr.io/k8s-staging-test-infra/gcb-docker-gcloud image is for Makefile build, maybe...?

Because simple build example uses gcr.io/cloud-builders/docker (and I followed it.)
https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md#simple-build-example

@Huang-Wei
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Huang-Wei,sanposhiho]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 69519f0 into kubernetes-sigs:master Dec 7, 2021
khalilswdp pushed a commit to khalilswdp/kube-scheduler-simulator that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants