-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest to run reset.yml
playbook for first-time users
#9865
Suggest to run reset.yml
playbook for first-time users
#9865
Conversation
Hi @kerryeon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @kerryeon, this looks reasonable to suggest this, thanks :D. Could you rebase your commit to retrigger the CI though? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/ok-to-test
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kerryeon, liupeng0518, MrFreezeex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Users who are new to
kubespray
may fail to deploy the cluster because they are inexperienced. The problem is that if thecluster.yml
playbook is re-executed after the first attempt fails, it fails again with a high probability even if the user-defined inventory is flawless.This is because even if the cluster installation fails, useless configuration files such as
/etc/kubernetes
remain andkubespray
tries to reuse them as much as possible. Therefore, when deploying for the first time, the users must execute thereset.yml
playbook before deploying to delete all configuration files and packages that may conflict.Unfortunately,
README.md
in the root directory is missing these important notices. I suggest runningreset.yml
in theUsage
script to lower the chance of errors for first-time users. I expect this will also lower the possibility of issues due to lack of experience.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: