Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cluster-Autoscaler's ProvisioningRequest via two-stage admission #1136

Closed
2 of 3 tasks
trasc opened this issue Sep 19, 2023 · 7 comments · Fixed by #1147 or #1154
Closed
2 of 3 tasks

Support Cluster-Autoscaler's ProvisioningRequest via two-stage admission #1136

trasc opened this issue Sep 19, 2023 · 7 comments · Fixed by #1147 or #1154
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@trasc
Copy link
Contributor

trasc commented Sep 19, 2023

What would you like to be added:

Use two-stage admission to support Cluster-Autoscaler's ProvisioningRequest

Why is this needed:

The ProvisioningRequest API allows to request new nodes without creating Pods. Kueue can use it to provide high guarantees that the admitted workloads will fit in the cluster.

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@trasc trasc added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 19, 2023
@trasc
Copy link
Contributor Author

trasc commented Sep 19, 2023

/assign

@tenzen-y
Copy link
Member

@trasc Could you update the issue description? I don't have any context as to why this feature is necessary.

@alculquicondor alculquicondor changed the title ProvisioningRequest Support Cluster-Autoscaler's ProvisioningRequest via two-stage admission Sep 19, 2023
@alculquicondor
Copy link
Contributor

Sorry about that @tenzen-y. Updated the description.

There is a KEP coming. We are thinking of using the cmd/experimental folder to avoid tying this to the release of 0.5

@alculquicondor
Copy link
Contributor

/assign @mwielgus
for design

@tenzen-y
Copy link
Member

Sorry about that @tenzen-y. Updated the description.

@alculquicondor Alright. Thank you for the updates :)

There is a KEP coming. We are thinking of using the cmd/experimental folder to avoid tying this to the release of 0.5

It makes sense. IIUC, ProvisioningRequest is not yet released.

@trasc
Copy link
Contributor Author

trasc commented Oct 11, 2023

/reopen
To continue tracking the implementation #1154

@k8s-ci-robot k8s-ci-robot reopened this Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

@trasc: Reopened this issue.

In response to this:

/reopen
To continue tracking the implementation #1154

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
5 participants