-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirements for v0.6 #1269
Comments
I will create an issue to add integration for the Serving use case by Kserve.
SGTM @alculquicondor #79 is already accepted? I think we should take carefully the feature since the feature will provide more complexity to kueue. Also, I think we should consider if Cohort can functional as an alternative of #79. |
Oh, it sounds like a nice idea. I can't wait for the KEP :) |
Some feedbacks from our team, hope to support:
Also, it will be great to to hava:
|
@alculquicondor should we graduate |
I cleaned up some of the issues. I would like to cut a release in the first week of February. #1282 has a basic form, but @tenzen-y wanted to add a few more knobs, which shouldn't be too controversial, so it can probably make it. I think #1224 is at risk. Last time I checked, the calculations were not quite right. Also it touches some crucial parts of the code, so there might not be enough time to spot bugs. Maybe we can be more coarse about using the feature gate to guard the behavior? In other words, call the feature gate a few times in top level functions, as opposed to call it in multiple smaller functions. Or we can leave it for 0.7 by April? @kerthcet is shepherding this. Thoughts? |
Yes, I want to include #1608 (Part-of #1282) in v0.6 since I changed the API change in #1608. The design is completed and waiting for the review now. Also, I want to include #1601 as much as possible, although I'm not sure that we should put it here due to only facing for developers. I believe that we can finalize #1601 by the end of January since the remaining task for #1601 is only one. |
@alculquicondor @mimowo Did you discuss #1269 (comment) anywhere?
|
Nope. But we are capacity constrained, so my answer is no for now. |
SGTM |
I'm wondering what is yet needed before graduation, because the KEP says just "User feedback is positive.". One benefit of graduating to Beta is that we could delete the manifest from DWS example, which currently is required to enable the feature gate. I share the sentiment that we should not prolong Kueue release just because of that. |
For #1224, I think the calculations is right now, you can take a look, especially the tests, I think we can finish this until the end of this week if everything goes well .. What's the planning day for new release? |
FYI, from Feb. 9th, we'll on holiday for Chinese New Year, we hope to finish this work before that time then little code conflicts to solve. 😢 |
I'm not familiar with GKE DWS. So, I leave a decision on @alculquicondor whether we include the graduation of ProbisioningACC. |
@kerthcet Our deadline is 8th Feb (9th Feb at Asia TZ). If all tasks are done earlier, we can release a new version at that time. |
Sure, it sounds like we don't need extra tests for now. Although thinking about metrics could be useful. I would be ok leaving it for the next release if @mimowo doesn't have time to think about this. |
I think it is better to leave for the next release in that case. |
This is the last piece of v0.6: #1709 |
Implementation is all done. We can work on documentation in parallel to the release steps. |
SGTM |
/close |
@alculquicondor: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Accepted
The text was updated successfully, but these errors were encountered: