[workload]Avoid unnecessary allocation in HasAllChecks #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
size/XS
tenzen-y
reviewed
Sep 27, 2023
pkg/workload/workload.go
Outdated
Comment on lines
452
to
454
| if len(mustHaveChecks) > len(wl.Status.AdmissionChecks) { | ||
| return false | ||
| } |
There was a problem hiding this comment.
Why do we use len(mustHaveChecks) here? We use mustHaveChecks.Len() in other places such as L448, L460.
There was a problem hiding this comment.
I forgot it's a set :). Done.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y, trasc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
trasc
force-pushed
the
speedup-has-all-checks
branch
from
e6cecb4
to
9ea9de7
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 58837e90cac8df5d71ac5cb4ed5819de81dce79e
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Avoids unnecessary allocation in workload.HasAllChecks
Which issue(s) this PR fixes:
Relates to: #1090
Special notes for your reviewer:
Does this PR introduce a user-facing change?