Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kueuectl] Support autocompletion on kueue CLI commands #2314

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[kueuectl] Support autocompletion on kueue CLI commands #2314

merged 1 commit into from
Jun 4, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented May 29, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support autocompletion on kueue CLI commands.

Which issue(s) this PR fixes:

Fixes #2295

Special notes for your reviewer:

Does this PR introduce a user-facing change?

CLI: Support autocompletion

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 29, 2024
@netlify Netlify
Copy link

netlify bot commented May 29, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 3a193b5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/665f4a9f23242c00082a86ac

@mbobrovskyi
Copy link
Contributor Author

/assign

@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-autocomplete branch 2 times, most recently from 441e6f2 to 8c5732d Compare May 29, 2024 14:21
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 29, 2024
@mbobrovskyi
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 29, 2024
@mbobrovskyi
Copy link
Contributor Author

/assign @trasc

@mbobrovskyi mbobrovskyi removed their assignment May 29, 2024
@mbobrovskyi
Copy link
Contributor Author

/cc @IrvingMg @vladikkuzn

@mbobrovskyi mbobrovskyi marked this pull request as ready for review May 30, 2024 14:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mimowo May 30, 2024 14:08
trasc
trasc reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@trasc trasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e804de214eaf281eb771ac1ba01014e8fe875003

@mbobrovskyi
Copy link
Contributor Author

/assign @alculquicondor

@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-autocomplete branch 3 times, most recently from 44d8505 to 094c634 Compare June 4, 2024 13:25
alculquicondor
alculquicondor reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
for nit

cmd/kueuectl/app/completion/completion.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 61b6e807fdd09b6a902c56c6ade38e8e9be94a04

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 4, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/kueuectl-autocomplete branch from 592f9ee to 3a193b5 Compare June 4, 2024 17:10
@alculquicondor
Copy link
Contributor

Please check integration failure

@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Jun 4, 2024 •
edited
Loading

@alculquicondor Looks like flakiness problem here.

[FAILED] Expected <string>: "... 1s" to equal | <string>: "... 0s"

It's not related for current changes. Should I fix it here or on another PR?

@mbobrovskyi
Copy link
Contributor Author

/test pull-kueue-test-integration-main

@alculquicondor
Copy link
Contributor

oh ok, yes, fix in a separate PR

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d646a7c5f36ffd05ff2e69b2b230ed9461ace185

@mbobrovskyi
Copy link
Contributor Author

Created issue #2353

@alculquicondor
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit bf05033 into kubernetes-sigs:main Jun 4, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jun 4, 2024
@mbobrovskyi mbobrovskyi deleted the feature/kueuectl-autocomplete branch June 11, 2024 15:52
@mbobrovskyi mbobrovskyi restored the feature/kueuectl-autocomplete branch June 11, 2024 15:52
@mbobrovskyi mbobrovskyi mentioned this pull request Jun 12, 2024
Closed
3 tasks
Fiona-Waters pushed a commit to Fiona-Waters/kueue that referenced this pull request Jun 25, 2024
@mbobrovskyi @Fiona-Waters
[kueuectl] Support autocompletion on kueue CLI commands (kubernetes-s…
6de83a8 
…igs#2314)
@alculquicondor
Copy link
Contributor

/release-note-edit

CLI: Support autocompletion

@mbobrovskyi mbobrovskyi deleted the feature/kueuectl-autocomplete branch July 18, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladikkuzn vladikkuzn vladikkuzn left review comments

@denkensk denkensk Awaiting requested review from denkensk

@kerthcet kerthcet Awaiting requested review from kerthcet

@IrvingMg IrvingMg Awaiting requested review from IrvingMg

@mimowo mimowo Awaiting requested review from mimowo

@trasc trasc Awaiting requested review from trasc

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@alculquicondor alculquicondor

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.

[kueuectl] Support autocompletion on kueue CLI commands
5 participants
@mbobrovskyi @k8s-ci-robot @alculquicondor @vladikkuzn @trasc