Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure PodsReadyTimeout integration tests with short timeout. #2329

Merged
merged 2 commits into from
May 30, 2024
Merged

Restructure PodsReadyTimeout integration tests with short timeout. #2329

merged 2 commits into from
May 30, 2024

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented May 30, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We should use a shorter timeout (10ms) for the test cases with a single or second reconciliation and should keep using a 1s for test cases with 3 reconciliations.

Which issue(s) this PR fixes:

Fixes #2285

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 30, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 30, 2024
@k8s-ci-robot k8s-ci-robot requested a review from trasc May 30, 2024 05:58
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 30, 2024
@netlify Netlify
Copy link

netlify bot commented May 30, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit ce2581d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66589a2ff44a040008eb47d8

@mbobrovskyi
Copy link
Contributor Author

/test all

@mbobrovskyi mbobrovskyi removed their assignment May 30, 2024
@mbobrovskyi
Copy link
Contributor Author

/assign @trasc

@mbobrovskyi mbobrovskyi force-pushed the cleanup/restructure-PodsReadyTimeout-integration-tests-with-short-timeout branch 2 times, most recently from 3be0921 to d687d09 Compare May 30, 2024 07:44
@mbobrovskyi mbobrovskyi force-pushed the cleanup/restructure-PodsReadyTimeout-integration-tests-with-short-timeout branch from d687d09 to b97107a Compare May 30, 2024 07:59
@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented May 30, 2024 •
edited
Loading

Integration passed 1/5

/test pull-kueue-test-integration-main

@mbobrovskyi
Copy link
Contributor Author

Integration passed 2/5

/test pull-kueue-test-integration-main

@mbobrovskyi
Copy link
Contributor Author

Integration passed 3/5

/test pull-kueue-test-integration-main

@mbobrovskyi
Copy link
Contributor Author

Integration passed 4/5

/test pull-kueue-test-integration-main

@mbobrovskyi
Copy link
Contributor Author

Integration passed 5/5

/test pull-kueue-test-integration-main

@mbobrovskyi
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 30, 2024
@mbobrovskyi
Copy link
Contributor Author

/cc @IrvingMg @vladikkuzn

@mbobrovskyi mbobrovskyi marked this pull request as ready for review May 30, 2024 14:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2024
alculquicondor
alculquicondor reviewed May 30, 2024
View reviewed changes
test/integration/scheduler/podsready/scheduler_test.go Outdated
Comment on lines 296 to 298
// We assume that the test will get to this check before the timeout expires and the
// kueue cancels the admission. Mentioning this in case this test flakes in the future.
gomega.Eventually(func() bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't think that 10ms for this in general.

Copy link
Contributor

@alculquicondor alculquicondor May 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the type of thing that might flake 1/100 times, which is still distracting.

Copy link
Contributor Author

@mbobrovskyi mbobrovskyi May 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I checked a lot and it worked fine. Moved to "Short PodsReady timeout" to be sure.

test/integration/scheduler/podsready/scheduler_test.go
@@ -628,9 +663,9 @@ var _ = ginkgo.Describe("SchedulerWithWaitForPodsReadyNonblockingMode", func() {
})
})

var _ = ginkgo.Context("Short PodsReady timeout", func() {
var _ = ginkgo.Context("Tiny PodsReady timeout", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have another context for this already?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For NonblockingMode no.

test/integration/scheduler/podsready/scheduler_test.go Outdated Show resolved Hide resolved
alculquicondor
alculquicondor reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a0436d2f41a7b48845a733fa3554dc212ca29485

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mbobrovskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit e2e2314 into kubernetes-sigs:main May 30, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone May 30, 2024
@mbobrovskyi mbobrovskyi deleted the cleanup/restructure-PodsReadyTimeout-integration-tests-with-short-timeout branch May 30, 2024 17:17
@mbobrovskyi mbobrovskyi mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

@trasc trasc Awaiting requested review from trasc

@IrvingMg IrvingMg Awaiting requested review from IrvingMg

@vladikkuzn vladikkuzn Awaiting requested review from vladikkuzn

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@alculquicondor alculquicondor

@trasc trasc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.

Restructure PodsReadyTimeout integration tests with short timeout
4 participants
@mbobrovskyi @k8s-ci-robot @alculquicondor @trasc